Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/content_settings/core/browser/content_settings_utils.h

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_utils.h
diff --git a/components/content_settings/core/browser/content_settings_utils.h b/components/content_settings/core/browser/content_settings_utils.h
index 2efa0ed4f9e8184afc12678dc10abad414dd400c..4fa558441e53c39e9b9e70babac7fc6386349c35 100644
--- a/components/content_settings/core/browser/content_settings_utils.h
+++ b/components/content_settings/core/browser/content_settings_utils.h
@@ -61,7 +61,9 @@ const char kExtensionScheme[] = "chrome-extension";
std::string ContentSettingToString(ContentSetting setting);
-ContentSetting ContentSettingFromString(const std::string& name);
+// Converts a content setting string to the corresponding ContentSetting.
+// Returns true if |name| specifies a valid content setting, false otherwise.
+bool ContentSettingFromString(const std::string& name, ContentSetting* setting);
// Converts |Value| to |ContentSetting|.
ContentSetting ValueToContentSetting(const base::Value* value);
« no previous file with comments | « chrome/test/data/policy/policy_test_cases.json ('k') | components/content_settings/core/browser/content_settings_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698