chrome/browser/resources/options/content_settings.html - Issue 1372353004: Making structure for ContentSettings and its corresponding strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings.html

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_store.cc ('k') | chrome/browser/resources/options/content_settings_exceptions_area.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/content_settings.html

diff --git a/chrome/browser/resources/options/content_settings.html b/chrome/browser/resources/options/content_settings.html

index b9f69f4c038e7191c48cc5348c0a1e4717fb88e4..803b8c06dc6f1bdd032ef5e6667a08a9778d48e7 100644

--- a/chrome/browser/resources/options/content_settings.html

+++ b/chrome/browser/resources/options/content_settings.html

@@ -18,11 +18,11 @@

</div>

<label>

- <input type="radio" name="cookies" value="session">

+ <input type="radio" name="cookies" value="session_only">

<span>

- <span i18n-content="cookiesSession"></span>

+ <span i18n-content="cookiesSessionOnly"></span>

<span class="controlled-setting-indicator"

- content-setting="cookies" value="session"></span>

+ content-setting="cookies" value="session_only"></span>

</span>

</label>

</div>

@@ -154,11 +154,11 @@

</div>

<label>

- <input type="radio" name="plugins" value="detect">

+ <input type="radio" name="plugins" value="detect_important_content">

<span>

- <span i18n-content="pluginsDetect"></span>

+ <span i18n-content="pluginsDetectImportantContent"></span>

<span class="controlled-setting-indicator"

- content-setting="plugins" value="detect"></span>

+ content-setting="plugins" value="detect_important_content"></span>

</span>

</label>

</div>