chrome/browser/ui/webui/options/content_settings_handler.cc - Issue 1372353004: Making structure for ContentSettings and its corresponding strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_helpers.cc ('K') | « chrome/browser/resources/options/content_settings_exceptions_area.js ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | components/content_settings/core/browser/content_settings_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/content_settings_handler.cc

diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc

index 5baf48d22995ef1c8d8db5290e96216f6a386f1e..3eae1d2194ea0a1c7dd5a73f4ba281d67e8cf64c 100644

--- a/chrome/browser/ui/webui/options/content_settings_handler.cc

+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc

@@ -352,7 +352,7 @@ void ContentSettingsHandler::GetLocalizedValues(

{"cookiesHeader", IDS_COOKIES_HEADER},

{"cookiesAllow", IDS_COOKIES_ALLOW_RADIO},

{"cookiesBlock", IDS_COOKIES_BLOCK_RADIO},

- {"cookiesSession", IDS_COOKIES_SESSION_ONLY_RADIO},

+ {"cookiesSessionOnly", IDS_COOKIES_SESSION_ONLY_RADIO},

{"cookiesBlock3rdParty", IDS_COOKIES_BLOCK_3RDPARTY_CHKBOX},

{"cookiesShowCookies", IDS_COOKIES_SHOW_COOKIES_BUTTON},

{"flashStorageSettings", IDS_FLASH_STORAGE_SETTINGS},

@@ -474,7 +474,7 @@ void ContentSettingsHandler::GetLocalizedValues(

int plugin_ids = default_value == CONTENT_SETTING_DETECT_IMPORTANT_CONTENT ?

IDS_PLUGIN_DETECT_RECOMMENDED_RADIO : IDS_PLUGIN_DETECT_RADIO;

- localized_strings->SetString("pluginsDetect",

+ localized_strings->SetString("pluginsDetectImportantContent",

l10n_util::GetStringUTF16(plugin_ids));

RegisterTitle(localized_strings, "contentSettingsPage",