chrome/browser/extensions/api/content_settings/content_settings_helpers.h - Issue 1372353004: Making structure for ContentSettings and its corresponding strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_helpers.h

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_api.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_helpers.cc » ('j') | chrome/browser/extensions/api/content_settings/content_settings_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_helpers.h

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_helpers.h b/chrome/browser/extensions/api/content_settings/content_settings_helpers.h

index ddd8dd9518c77f3308054248d7334c70c1724a04..b2203095df853c9dbb25b423c1391dfd7de81e5a 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_helpers.h

+++ b/chrome/browser/extensions/api/content_settings/content_settings_helpers.h

@@ -35,8 +35,6 @@ std::string ContentSettingsTypeToString(ContentSettingsType type);

// false otherwise.

bool StringToContentSetting(const std::string& setting_str,

Bernhard Bauer 2015/10/06 15:37:25 Let's remove this method, change the other's signa

Deepak 2015/10/07 04:39:43 Done.

ContentSetting* setting);

-// Returns a string representation of a ContentSetting.

-const char* ContentSettingToString(ContentSetting setting);

} // namespace content_settings_helpers

} // namespace extensions