chrome/browser/android/preferences/pref_service_bridge.cc - Issue 1372353004: Making structure for ContentSettings and its corresponding strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/content_settings/content_settings_api.cc » ('j') | chrome/browser/extensions/api/content_settings/content_settings_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/preferences/pref_service_bridge.cc

diff --git a/chrome/browser/android/preferences/pref_service_bridge.cc b/chrome/browser/android/preferences/pref_service_bridge.cc

index 963a006f59bbcb27e216e90caece5cb4f1c516cd..aa219f514cba4225251358ac79d34951ac477082 100644

--- a/chrome/browser/android/preferences/pref_service_bridge.cc

+++ b/chrome/browser/android/preferences/pref_service_bridge.cc

@@ -85,9 +85,9 @@ std::string GetStringForContentSettingsType(

case CONTENT_SETTING_ASK:

return "ask";

case CONTENT_SETTING_SESSION_ONLY:

- return "session";

+ return "session_only";

Bernhard Bauer 2015/10/05 12:34:28 I think you need to update the corresponding Web U

Deepak 2015/10/05 14:25:32 Done.

case CONTENT_SETTING_DETECT_IMPORTANT_CONTENT:

- return "detect";

+ return "detect_important_content";

case CONTENT_SETTING_NUM_SETTINGS:

return "num_settings";

case CONTENT_SETTING_DEFAULT: