Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 1372353004: Making structure for ContentSettings and its corresponding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h" 5 #include "chrome/browser/extensions/api/content_settings/content_settings_store. h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/debug/alias.h" 9 #include "base/debug/alias.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 rule.primary_pattern.ToString()); 264 rule.primary_pattern.ToString());
265 setting_dict->SetString(keys::kSecondaryPatternKey, 265 setting_dict->SetString(keys::kSecondaryPatternKey,
266 rule.secondary_pattern.ToString()); 266 rule.secondary_pattern.ToString());
267 setting_dict->SetString( 267 setting_dict->SetString(
268 keys::kContentSettingsTypeKey, 268 keys::kContentSettingsTypeKey,
269 helpers::ContentSettingsTypeToString(it->first.content_type)); 269 helpers::ContentSettingsTypeToString(it->first.content_type));
270 setting_dict->SetString(keys::kResourceIdentifierKey, 270 setting_dict->SetString(keys::kResourceIdentifierKey,
271 it->first.resource_identifier); 271 it->first.resource_identifier);
272 ContentSetting content_setting = ValueToContentSetting(rule.value.get()); 272 ContentSetting content_setting = ValueToContentSetting(rule.value.get());
273 DCHECK_NE(CONTENT_SETTING_DEFAULT, content_setting); 273 DCHECK_NE(CONTENT_SETTING_DEFAULT, content_setting);
274 setting_dict->SetString( 274
275 keys::kContentSettingKey, 275 std::string setting_string;
276 helpers::ContentSettingToString(content_setting)); 276 bool return_value = content_settings::ContentSettingToString(
277 content_setting, &setting_string);
278 DCHECK(return_value);
279
280 setting_dict->SetString(keys::kContentSettingKey, setting_string);
277 settings->Append(setting_dict); 281 settings->Append(setting_dict);
278 } 282 }
279 } 283 }
280 return settings; 284 return settings;
281 } 285 }
282 286
283 void ContentSettingsStore::SetExtensionContentSettingFromList( 287 void ContentSettingsStore::SetExtensionContentSettingFromList(
284 const std::string& extension_id, 288 const std::string& extension_id,
285 const base::ListValue* list, 289 const base::ListValue* list,
286 ExtensionPrefsScope scope) { 290 ExtensionPrefsScope scope) {
(...skipping 21 matching lines...) Expand all
308 ContentSettingsType content_settings_type = 312 ContentSettingsType content_settings_type =
309 helpers::StringToContentSettingsType(content_settings_type_str); 313 helpers::StringToContentSettingsType(content_settings_type_str);
310 DCHECK_NE(CONTENT_SETTINGS_TYPE_DEFAULT, content_settings_type); 314 DCHECK_NE(CONTENT_SETTINGS_TYPE_DEFAULT, content_settings_type);
311 315
312 std::string resource_identifier; 316 std::string resource_identifier;
313 dict->GetString(keys::kResourceIdentifierKey, &resource_identifier); 317 dict->GetString(keys::kResourceIdentifierKey, &resource_identifier);
314 318
315 std::string content_setting_string; 319 std::string content_setting_string;
316 dict->GetString(keys::kContentSettingKey, &content_setting_string); 320 dict->GetString(keys::kContentSettingKey, &content_setting_string);
317 ContentSetting setting = CONTENT_SETTING_DEFAULT; 321 ContentSetting setting = CONTENT_SETTING_DEFAULT;
318 bool result = 322 bool result = content_settings::ContentSettingFromString(
319 helpers::StringToContentSetting(content_setting_string, &setting); 323 content_setting_string, &setting);
320 DCHECK(result); 324 DCHECK(result);
321 325
322 SetExtensionContentSetting(extension_id, 326 SetExtensionContentSetting(extension_id,
323 primary_pattern, 327 primary_pattern,
324 secondary_pattern, 328 secondary_pattern,
325 content_settings_type, 329 content_settings_type,
326 resource_identifier, 330 resource_identifier,
327 setting, 331 setting,
328 scope); 332 scope);
329 } 333 }
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 ContentSettingsStore::FindEntry(const std::string& ext_id) const { 372 ContentSettingsStore::FindEntry(const std::string& ext_id) const {
369 ExtensionEntryMap::const_iterator i; 373 ExtensionEntryMap::const_iterator i;
370 for (i = entries_.begin(); i != entries_.end(); ++i) { 374 for (i = entries_.begin(); i != entries_.end(); ++i) {
371 if (i->second->id == ext_id) 375 if (i->second->id == ext_id)
372 return i; 376 return i;
373 } 377 }
374 return entries_.end(); 378 return entries_.end();
375 } 379 }
376 380
377 } // namespace extensions 381 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698