Leak per-isolate data in pdfium

Leak per-isolate data in pdfium

Right now we're freeing per-isolate data everytime a document is destroyed even
though it may be in use by other documents. For now we leak the per-isolate
data until crbug.com/531339 is fixed.

BUG=531339
R=jochen@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3e144b8c23d7c52ed36329e87f0cb01f38ec1ed7

[raymes, 2015-09-29 08:04:17]

raymes@chromium.org changed reviewers:
+ jochen@chromium.org, thestig@chromium.org

[raymes, 2015-09-29 08:04:17]

PTAL - I haven't had a chance to test it yet but will tomorrow morning :)

[jochen (gone - plz use gerrit), 2015-09-29 10:08:10]

lgtm

[jochen (gone - plz use gerrit), 2015-09-29 10:34:00]

On 2015/09/29 at 10:08:10, jochen wrote:
> lgtm

thestig: some background... in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/pdfium...
we already check that we only create the per isolate data once

[raymes, 2015-09-30 01:44:18]

raymes@chromium.org changed reviewers:
+ tsepez@chromium.org

[raymes, 2015-09-30 01:44:19]

I tested this following the instructions on the bug and it seems to fix the
problem. It's ready to land but I'm not sure I can land it:

$ git cl land
...
fatal: remote error: Access denied to raymes@google.com

Maybe one of you guys can? Thanks!

[jochen (gone - plz use gerrit), 2015-09-30 09:46:50]

Committed patchset #3 (id:40001) manually as
3e144b8c23d7c52ed36329e87f0cb01f38ec1ed7 (presubmit successful).

[jochen (gone - plz use gerrit), 2015-09-30 09:47:06]

On 2015/09/30 at 01:44:19, raymes wrote:
> I tested this following the instructions on the bug and it seems to fix the
problem. It's ready to land but I'm not sure I can land it:
> 
> $ git cl land
> ...
> fatal: remote error: Access denied to raymes@google.com
> 
> Maybe one of you guys can? Thanks!

done