third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h - Issue 1372343002: Crash fix: Avoid using stale HTMLToken after tree construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h

Issue 1372343002: Crash fix: Avoid using stale HTMLToken after tree construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add TODO about mutation Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/parser/strip-script-attrs-on-input-expected.txt ('k') | third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h

index e6eb94be0915e77098ac7f73d77c65b23fe33e3a..d69b955da46f7f8518514ba7e71a077fce7119ef 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h

@@ -207,6 +207,7 @@ private:

RefPtrWillBeMember<HTMLStackItem> m_contextElementStackItem;

};

+ // https://html.spec.whatwg.org/#frameset-ok-flag

bool m_framesetOk;

#if ENABLE(ASSERT)

bool m_isAttached;