|
Revert of Replace RenderFullScreen with top layer ( https://codereview.chromium.org/139743005/)
Reason for revert:
This patch seems to be causing crashs on windows 7 debug build.
http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13317
Original issue's description:
> Replace RenderFullScreen with top layer
>
> This patch makes the Fullscreen API use the top layer, as per the latest
> Fullscreen spec:
> http://fullscreen.spec.whatwg.org/
>
> Some more details:
> - HTMLPlugInElement now retains its widget during reattach. Otherwise,
> a video would need to be reloaded when it enters fullscreen.
> - The placeholder renderer that was in RenderFullScreen is removed. The
> spec doesn't mention such a mechanism and it's better to avoid the
> complexity if possible. It was originally added to prevent a flash of a
> collapsed page when exiting fullscreen:
> https://bugs.webkit.org/show_bug.cgi?id=61897
> It's possible we still need it. Either way, it has to be moved from
> RenderFullScreen.
>
> Intent to ship:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yJUanvg7d40
>
> BUG= 240576, 246077
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165710
TBR=esprehn@chromium.org,jchaffraix@chromium.org,trchen@chromium.org,eseidel@chromium.org,wjmaclean@chromium.org,falken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 240576, 246077
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+475 lines, -277 lines) |
Patch |
 |
M |
LayoutTests/TestExpectations
|
View
|
|
3 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html
|
View
|
|
1 chunk |
+0 lines, -105 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fullscreen/full-screen-is-in-top-layer.html
|
View
|
|
1 chunk |
+0 lines, -40 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fullscreen/full-screen-placeholder.html
|
View
|
|
1 chunk |
+73 lines, -0 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/fullscreen/full-screen-placeholder-expected.txt
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fullscreen/full-screen-video-has-backdrop.html
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
A |
LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png
|
View
|
|
Binary file |
0 comments
|
Download
|
 |
M |
Source/core/core.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/fullscreen.css
|
View
|
|
1 chunk |
+1 line, -22 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/Document.cpp
|
View
|
|
1 chunk |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/Element.cpp
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/FullscreenElementStack.h
|
View
|
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/FullscreenElementStack.cpp
|
View
|
|
10 chunks |
+50 lines, -14 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/RenderTreeBuilder.cpp
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLDialogElement.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLDialogElement.cpp
|
View
|
|
4 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLPlugInElement.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLPlugInElement.cpp
|
View
|
|
3 chunks |
+1 line, -16 lines |
0 comments
|
Download
|
 |
A |
Source/core/rendering/RenderFullScreen.h
|
View
|
|
1 chunk |
+60 lines, -0 lines |
0 comments
|
Download
|
 |
A |
Source/core/rendering/RenderFullScreen.cpp
|
View
|
|
1 chunk |
+189 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderInline.cpp
|
View
|
|
2 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderLayerCompositor.cpp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderVideo.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderVideo.cpp
|
View
|
|
2 chunks |
+42 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|