Support relative file paths in FilePathToFileURL().

Support relative file paths in FilePathToFileURL().

This makes it possible for content_shell to resolve relative file paths
on the command line and turn them into proper startup URLs.

BUG=336416
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246278

[mstensho (USE GERRIT), 2014-01-21 15:13:07]

Since FilePathToFileURL() just returned a bogus URL when passed a relative path,
I decided to fix it there. If resolving relative paths there is considered
harmful or wrong, another option would be to make a more local fix in
GetStartupURL() (content/shell/browser/shell_browser_main_parts.cc).

Furthermore, I'm unfamiliar with this code, and may easily have missed better
utility functions that I could have used. In that case, please enlighten me. :)

[abarth-chromium, 2014-01-21 21:35:25]

On 2014/01/21 15:13:07, Morten Stenshorne wrote:
> If resolving relative paths there is considered
> harmful or wrong, another option would be to make a more local fix in
> GetStartupURL() (content/shell/browser/shell_browser_main_parts.cc).

IMHO, that's a better option, but I'm not an OWNER for either of these files. 
For example, the --dump-render-tree option already support relative URL
resolution.

> Furthermore, I'm unfamiliar with this code, and may easily have missed better
> utility functions that I could have used. In that case, please enlighten me.
:)

We can ask the OWNERS of this code for guidance.  Take a look at OWNERS files in
these directories to see who we should contact.

[mstensho (USE GERRIT), 2014-01-21 22:10:40]

@wtc - do you have an opinion?

[wtc, 2014-01-21 22:25:36]

Patch set 1 LGTM.

I guess a file:// URL cannot contain a relative pathname?

https://codereview.chromium.org/137233006/diff/1/net/base/net_util.cc
File net/base/net_util.cc (right):

https://codereview.chromium.org/137233006/diff/1/net/base/net_util.cc#newcode...
net/base/net_util.cc:1005: url_string.append(1, base::FilePath::kSeparators[0]);

Nit: you can use push_back to append just one character.

[mstensho (USE GERRIT), 2014-01-22 06:19:28]

On 2014/01/21 22:25:36, wtc wrote:
> Patch set 1 LGTM.
> 
> I guess a file:// URL cannot contain a relative pathname?

That's right.

> https://codereview.chromium.org/137233006/diff/1/net/base/net_util.cc
> File net/base/net_util.cc (right):
> 
>
https://codereview.chromium.org/137233006/diff/1/net/base/net_util.cc#newcode...
> net/base/net_util.cc:1005: url_string.append(1,
base::FilePath::kSeparators[0]);
> 
> Nit: you can use push_back to append just one character.

OK, I'll do that before committing.

[commit-bot: I haz the power, 2014-01-22 06:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/137233006/70001

[commit-bot: I haz the power, 2014-01-22 10:41:30]

Change committed as 246278