Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137233005: CSP: Improve blocked inline script error message. (Closed)

Created:
6 years, 11 months ago by Mike West
Modified:
6 years, 11 months ago
CC:
blink-reviews, mkwst+watchlist_chromium.org, jww
Visibility:
Public.

Description

CSP: Improve blocked inline script error message. The message should make it clear that a lack of 'unsafe-inline' causes script/style to be blocked. This patch adds a sentence to that effect. BUG=332283, 270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165466

Patch Set 1 #

Patch Set 2 : Appengine. :( #

Patch Set 3 : Yay. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -56 lines) Patch
M LayoutTests/http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-and-scripthash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-basic-blocked-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/stylenonce-blocked-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/cached-frame-csp-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/injected-inline-script-blocked-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/injected-inline-style-blocked-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/isolatedWorld/bypass-main-world-csp-for-inline-script-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/debugger-pause-on-blocked-event-handler-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-pause-on-blocked-script-injection-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-pause-on-blocked-script-url-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ContentSecurityPolicy.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Hi Jochen. :) +jww, FYI.
6 years, 11 months ago (2014-01-21 11:38:01 UTC) #1
jochen (gone - plz use gerrit)
On 2014/01/21 11:38:01, Mike West wrote: > Hi Jochen. :) > > +jww, FYI. plz ...
6 years, 11 months ago (2014-01-21 11:42:00 UTC) #2
Mike West
Reuploaded.
6 years, 11 months ago (2014-01-21 11:46:51 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-21 11:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/137233005/60001
6 years, 11 months ago (2014-01-21 11:50:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/137233005/190001
6 years, 11 months ago (2014-01-21 14:06:52 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 16:25:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 165466

Powered by Google App Engine
This is Rietveld 408576698