Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1372323003: Revert of Flip Google Chrome Linux x64 bot from GYP to GN. (Closed)

Created:
5 years, 2 months ago by yoichio
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_perf_to_gn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip Google Chrome Linux x64 bot from GYP to GN. (patchset #1 id:1 of https://codereview.chromium.org/1377533002/ ) Reason for revert: This causes compile error on linux. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/42676 Original issue's description: > Flip Google Chrome Linux x64 bot from GYP to GN. > > This is on the chromium.chrome waterfall. > > R=brettw@chromium.org > BUG=432959 > > Committed: https://crrev.com/05ae5552d40ed73a8b7c1e9222caa30806682f73 > Cr-Commit-Position: refs/heads/master@{#351222} TBR=brettw@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=432959 Committed: https://crrev.com/255d29596dd6e34065a6782c1d163543c4520224 Cr-Commit-Position: refs/heads/master@{#351229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yoichio
Created Revert of Flip Google Chrome Linux x64 bot from GYP to GN.
5 years, 2 months ago (2015-09-29 01:46:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372323003/1
5 years, 2 months ago (2015-09-29 01:47:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 01:49:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/255d29596dd6e34065a6782c1d163543c4520224 Cr-Commit-Position: refs/heads/master@{#351229}
5 years, 2 months ago (2015-09-29 01:50:02 UTC) #4
Dirk Pranke
5 years, 2 months ago (2015-09-29 02:16:08 UTC) #5
Message was sent while issue was closed.
On 2015/09/29 01:50:02, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/255d29596dd6e34065a6782c1d163543c4520224
> Cr-Commit-Position: refs/heads/master@{#351229}

lgtm

Powered by Google App Engine
This is Rietveld 408576698