Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1372313004: Update to libpng 1.2.52 (rollup change only) (Closed)

Created:
5 years, 2 months ago by mdempsky
Modified:
5 years, 2 months ago
Reviewers:
Noel Gordon, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update to libpng 1.2.52 (rollup change only) Verified that both of the fixes mentioned in README.chromium were fixed in upstream. Upstream used a slightly different approach to detecting whether "prefix_size + expanded_size + 1" overflows in pngrutil.c, but their solution looks okay too. TBR=darin@chromium.org BUG=532758 Committed: https://crrev.com/6d08cb245c6d904a9b0ffe745ea98bb73fdd9a00 Cr-Commit-Position: refs/heads/master@{#351445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -791 lines) Patch
M third_party/libpng/LICENSE View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libpng/README View 7 chunks +18 lines, -10 lines 0 comments Download
M third_party/libpng/README.chromium View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/libpng/png.h View 12 chunks +42 lines, -17 lines 0 comments Download
M third_party/libpng/png.c View 7 chunks +11 lines, -19 lines 0 comments Download
M third_party/libpng/pngconf.h View 3 chunks +15 lines, -3 lines 0 comments Download
M third_party/libpng/pngerror.c View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/libpng/pnggccrd.c View 2 chunks +16 lines, -93 lines 0 comments Download
M third_party/libpng/pngget.c View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/libpng/pngpread.c View 6 chunks +4 lines, -537 lines 0 comments Download
M third_party/libpng/pngread.c View 8 chunks +19 lines, -32 lines 0 comments Download
M third_party/libpng/pngrtran.c View 5 chunks +11 lines, -2 lines 0 comments Download
M third_party/libpng/pngrutil.c View 9 chunks +21 lines, -32 lines 0 comments Download
M third_party/libpng/pngset.c View 11 chunks +34 lines, -19 lines 0 comments Download
M third_party/libpng/pngvcrd.c View 1 chunk +12 lines, -1 line 0 comments Download
M third_party/libpng/pngwrite.c View 4 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
mdempsky
5 years, 2 months ago (2015-09-29 19:44:38 UTC) #2
Noel Gordon
Right, layout tests passing and a good sign: LayoutTests/fast/images/png-suite/* gives us coverage, text chunk reading ...
5 years, 2 months ago (2015-09-29 23:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372313004/1
5 years, 2 months ago (2015-09-29 23:58:29 UTC) #5
Noel Gordon
TBR=darin for a third_party landing (daring: nothing to do here).
5 years, 2 months ago (2015-09-29 23:59:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 00:11:43 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d08cb245c6d904a9b0ffe745ea98bb73fdd9a00 Cr-Commit-Position: refs/heads/master@{#351445}
5 years, 2 months ago (2015-09-30 00:13:12 UTC) #8
Noel Gordon
On 2015/09/30 00:11:43, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) Fascinating: ...
5 years, 2 months ago (2015-09-30 00:14:03 UTC) #9
Noel Gordon
On 2015/09/30 00:14:03, noel gordon wrote: > On 2015/09/30 00:11:43, commit-bot: I haz the power ...
5 years, 2 months ago (2015-09-30 00:14:47 UTC) #10
Lei Zhang
Uh, a) darin isn't actually CC'd on the bug, and b) darin isn't in third_party/OWNERS.
5 years, 2 months ago (2015-09-30 00:24:49 UTC) #11
Noel Gordon
5 years, 2 months ago (2015-09-30 02:05:49 UTC) #12
Message was sent while issue was closed.
On 2015/09/30 00:24:49, Lei Zhang wrote:
> Uh, a) darin isn't actually CC'd on the bug, and b) darin isn't in
> third_party/OWNERS.

So did you notice haw that does not bug him, and that he is a top-level owner?
And we have been using this procedure for years ...

Powered by Google App Engine
This is Rietveld 408576698