Chromium Code Reviews
Help | Chromium Project | Sign in
(196)

Issue 13723005: <blink> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by jochen (OOO until Apr 22)
Modified:
10 months, 2 weeks ago
CC:
blink-reviews_chromium.org, darktears31
Visibility:
Public.

Description

<blink>

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Lint Patch
M Source/WebCore/css/html.css View 1 chunk +12 lines, -0 lines 3 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 19
M-A Ruel
totally lgtm
1 year ago #1
dglazkov (away until April 21)
Finally!
1 year ago #2
Mike West
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; 1s seems arbitrary. What do other browsers ...
1 year ago #3
M-A Ruel
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; On 2013/04/05 16:44:07, Mike West (chromium) wrote: ...
1 year ago #4
Dirk Pranke
lgtm.
1 year ago #5
eseidel
lbtm :p
1 year ago #6
jochen (OOO until Apr 22)
On 2013/04/05 19:53:48, Eric Seidel (Google) wrote: > lbtm :p why so negative Eric?
1 year ago #7
Avi
Everyone asks "how do I know if my Chrome is powered by Blink?" LGTM. We ...
1 year ago #8
pepelsbey
> Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; > 1s seems arbitrary. What do other browsers do here? Opera ...
1 year ago #9
eseidel
I think the chrome logo (which already looks a little like an eye) should just ...
1 year ago #10
eseidel
I think the chrome logo (which already looks a little like an eye) should just ...
1 year ago #11
Avi
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; On 2013/04/05 16:44:07, Mike West (chromium) wrote: ...
1 year ago #12
Marek Stępień
Any reason why this is being implemented via CSS animations instead of supporting `text-decoration: blink` ...
1 year ago #13
Masayuki Nakano (Mozilla Japan
Hello, Mozilla is now trying to drop blink effect completely. https://bugzilla.mozilla.org/show_bug.cgi?id=857820 The reason is, after ...
1 year ago #14
Masayuki Nakano (Mozilla Japan
Additionaly, please test |data:text/html,<blink>aaa<input></blink>|. Looks like the patch makes any contents of <blink> elements. But ...
1 year ago #15
mathias
“We will not ship the <blink> tag [sic], that’s for sure.” — Alex Komoroske, two ...
1 year ago #16
dglazkov (away until April 21)
Okay, enough scaring interwebs :)
1 year ago #17
jochen (OOO until Apr 22)
On 2013/04/06 14:57:48, Dimitri Glazkov wrote: > Okay, enough scaring interwebs :) I see, maybe ...
1 year ago #18
master.fon502
10 months, 2 weeks ago #19
Message was sent while issue was closed.
On 2013/04/05 21:58:49, eseidel wrote:
> I think the chrome logo (which already looks a little like an eye) should just
> be taught how to blink at infrequent intervals for blink builds. :p

 I think that that's an absolutely brilliant idea and somebody needs to bring
that to life to see how it would be
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6