Chromium Code Reviews
Help | Chromium Project | Sign in
(13)

Issue 13723005: <blink> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by jochen
Modified:
1 year, 10 months ago
CC:
blink-reviews, Alexis Menard
Visibility:
Public.

Description

<blink>

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/WebCore/css/html.css View 1 chunk +12 lines, -0 lines 3 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 19 (0 generated)
M-A Ruel
totally lgtm
2 years ago (2013-04-05 15:23:03 UTC) #1
dglazkov
Finally!
2 years ago (2013-04-05 16:38:44 UTC) #2
Mike West (traveling. slow.)
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; 1s seems arbitrary. What do other browsers ...
2 years ago (2013-04-05 16:44:07 UTC) #3
M-A Ruel
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; On 2013/04/05 16:44:07, Mike West (chromium) wrote: ...
2 years ago (2013-04-05 16:49:51 UTC) #4
Dirk Pranke
lgtm.
2 years ago (2013-04-05 19:27:10 UTC) #5
eseidel
lbtm :p
2 years ago (2013-04-05 19:53:48 UTC) #6
jochen
On 2013/04/05 19:53:48, Eric Seidel (Google) wrote: > lbtm :p why so negative Eric?
2 years ago (2013-04-05 20:17:46 UTC) #7
Avi
Everyone asks "how do I know if my Chrome is powered by Blink?" LGTM. We ...
2 years ago (2013-04-05 21:38:44 UTC) #8
pepelsbey
> Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; > 1s seems arbitrary. What do other browsers do here? Opera ...
2 years ago (2013-04-05 21:39:17 UTC) #9
eseidel
I think the chrome logo (which already looks a little like an eye) should just ...
2 years ago (2013-04-05 21:58:49 UTC) #10
eseidel
I think the chrome logo (which already looks a little like an eye) should just ...
2 years ago (2013-04-05 21:58:49 UTC) #11
Avi
https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css File Source/WebCore/css/html.css (right): https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#newcode1205 Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s; On 2013/04/05 16:44:07, Mike West (chromium) wrote: ...
2 years ago (2013-04-05 22:00:07 UTC) #12
Marek Stępień
Any reason why this is being implemented via CSS animations instead of supporting `text-decoration: blink` ...
2 years ago (2013-04-05 22:54:06 UTC) #13
Masayuki Nakano (Mozilla Japan
Hello, Mozilla is now trying to drop blink effect completely. https://bugzilla.mozilla.org/show_bug.cgi?id=857820 The reason is, after ...
2 years ago (2013-04-05 23:38:47 UTC) #14
Masayuki Nakano (Mozilla Japan
Additionaly, please test |data:text/html,<blink>aaa<input></blink>|. Looks like the patch makes any contents of <blink> elements. But ...
2 years ago (2013-04-06 00:11:05 UTC) #15
mathias
“We will not ship the <blink> tag [sic], that’s for sure.” — Alex Komoroske, two ...
2 years ago (2013-04-06 07:24:41 UTC) #16
dglazkov
Okay, enough scaring interwebs :)
2 years ago (2013-04-06 14:57:48 UTC) #17
jochen
On 2013/04/06 14:57:48, Dimitri Glazkov wrote: > Okay, enough scaring interwebs :) I see, maybe ...
2 years ago (2013-04-06 15:46:25 UTC) #18
master.fon502
1 year, 10 months ago (2013-06-05 04:02:34 UTC) #19
Message was sent while issue was closed.
On 2013/04/05 21:58:49, eseidel wrote:
> I think the chrome logo (which already looks a little like an eye) should just
> be taught how to blink at infrequent intervals for blink builds. :p

 I think that that's an absolutely brilliant idea and somebody needs to bring
that to life to see how it would be
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771