<blink>

<blink>

[M-A Ruel, 2013-04-05 15:23:03]

totally lgtm

[dglazkov, 2013-04-05 16:38:44]

Finally!

[Mike West, 2013-04-05 16:44:07]

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css
File Source/WebCore/css/html.css (right):

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#n...
Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s;
1s seems arbitrary. What do other browsers do here?

[M-A Ruel, 2013-04-05 16:49:51]

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css
File Source/WebCore/css/html.css (right):

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#n...
Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s;
On 2013/04/05 16:44:07, Mike West (chromium) wrote:
> 1s seems arbitrary. What do other browsers do here?

It's the right value.

" The United States Federal Government's Section 508 states that pages should
avoid causing the screen to flicker with a frequency between 2 Hz and 55 Hz, a
range which covers rapidly blinking text. This does not seem to apply to blink
element itself, which blinks at frequency of 1 Hz. "

Reference: http://en.wikipedia.org/wiki/Blink_element

[Dirk Pranke, 2013-04-05 19:27:10]

lgtm.

[eseidel, 2013-04-05 19:53:48]

lbtm :p

[jochen (gone - plz use gerrit), 2013-04-05 20:17:46]

On 2013/04/05 19:53:48, Eric Seidel (Google) wrote:
> lbtm :p

why so negative Eric?

[Avi (use Gerrit), 2013-04-05 21:38:44]

Everyone asks "how do I know if my Chrome is powered by Blink?" LGTM. We
seriously need to have this feature, at least for the first few versions of
blinkered chrome.

[pepelsbey, 2013-04-05 21:39:17]

> Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s;
> 1s seems arbitrary. What do other browsers do here?

Opera is doing 1s, Firefox 0.6s. And here's another code variation:

@-webkit-keyframes blink { 50% { visibility:hidden; }}
blink { -webkit-animation:blink 1s step-end infinite; }

[eseidel, 2013-04-05 21:58:49]

I think the chrome logo (which already looks a little like an eye) should just
be taught how to blink at infrequent intervals for blink builds. :p

[eseidel, 2013-04-05 21:58:49]

I think the chrome logo (which already looks a little like an eye) should just
be taught how to blink at infrequent intervals for blink builds. :p

[Avi (use Gerrit), 2013-04-05 22:00:07]

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css
File Source/WebCore/css/html.css (right):

https://codereview.chromium.org/13723005/diff/1/Source/WebCore/css/html.css#n...
Source/WebCore/css/html.css:1205: -webkit-animation-duration: 1s;
On 2013/04/05 16:44:07, Mike West (chromium) wrote:
> 1s seems arbitrary. What do other browsers do here?

According to Wikipedia, "In Mozilla Firefox the text alternates between being
visible for three quarters of a second and being invisible for one quarter of a
second."

It's clear to me that we should follow their lead. The danger I see here is that
site owners may have designed their sites for that blink frequency (say, by
coordinating it with animated GIFs), and we run the risk of incompatibility if
we don't mimic them well.

[Marek Stępień, 2013-04-05 22:54:06]

Any reason why this is being implemented via CSS animations instead of
supporting `text-decoration: blink` from CSS2.1, like Gecko and Presto do?

http://www.w3.org/TR/CSS21/text.html#lining-striking-props
http://mxr.mozilla.org/mozilla-central/source/layout/style/html.css#512

Gecko and Presto behavior is also consistent with HTML5's default stylesheet:
http://www.w3.org/TR/html5/rendering.html#phrasing-content-0

With this CL, if a web developer (for whatever reason) wants to cancel blinking
of <blink> elements, you require her to write:

blink {
  -webkit-animation: none;
  text-decoration: none;
}

[Masayuki Nakano (Mozilla Japan, 2013-04-05 23:38:47]

Hello, Mozilla is now trying to drop blink effect completely.
https://bugzilla.mozilla.org/show_bug.cgi?id=857820

The reason is, after Presto has gone, Gecko will be the only major browser
supporting blink. Then, there is no merit to keep supporting it.

[Masayuki Nakano (Mozilla Japan, 2013-04-06 00:11:05]

Additionaly, please test |data:text/html,<blink>aaa<input></blink>|.

Looks like the patch makes any contents of <blink> elements. But both Gecko and
Presto only support text blink because it's one of a feature of text-decoration.

[mathias, 2013-04-06 07:24:41]

“We will not ship the <blink> tag [sic], that’s for sure.” — Alex Komoroske, two
days ago (http://www.youtube.com/watch?v=TlJob8K_OwE#t=30m20s)

[dglazkov, 2013-04-06 14:57:48]

Okay, enough scaring interwebs :)

[jochen (gone - plz use gerrit), 2013-04-06 15:46:25]

On 2013/04/06 14:57:48, Dimitri Glazkov wrote:
> Okay, enough scaring interwebs :)

I see, maybe the web is just not ready yet

[master.fon502, 2013-06-05 04:02:34]

On 2013/04/05 21:58:49, eseidel wrote:
> I think the chrome logo (which already looks a little like an eye) should just
> be taught how to blink at infrequent intervals for blink builds. :p

 I think that that's an absolutely brilliant idea and somebody needs to bring
that to life to see how it would be