Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1372293005: [Interpreter] Support top-level code. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
oth, Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Support top-level code. Adds support for compiling top level code to bytecode to be run in the interpreter. Also moves PassesFilter to String:: so that it can be used to filter top level script names as well as functions (used in https://codereview.chromium.org/1379093002/) BUG=v8:4280 LOG=N Committed: https://crrev.com/c5528ac1cba36eba4cc17cedb2ad137432e49668 Cr-Commit-Position: refs/heads/master@{#31142}

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : Add Todos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
M src/compiler.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 4 chunks +21 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +36 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372293005/1
5 years, 2 months ago (2015-10-01 07:29:34 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 07:53:06 UTC) #4
rmcilroy
Michi, Orion, please take a look, thanks.
5 years, 2 months ago (2015-10-01 08:13:11 UTC) #6
oth
Looks good here.
5 years, 2 months ago (2015-10-01 08:39:49 UTC) #7
rmcilroy
Michi: Any comments?
5 years, 2 months ago (2015-10-02 12:32:50 UTC) #8
rmcilroy
On 2015/10/02 12:32:50, rmcilroy wrote: > Michi: Any comments? Ping?
5 years, 2 months ago (2015-10-06 07:49:33 UTC) #9
Michael Starzinger
LGTM to unblock things. I am fine with addressing my issues later and just having ...
5 years, 2 months ago (2015-10-07 09:53:29 UTC) #10
rmcilroy
Thanks Michi. TODOs added. Happy to help address the TODOs once you've got compiler.cc the ...
5 years, 2 months ago (2015-10-07 10:05:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372293005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372293005/40001
5 years, 2 months ago (2015-10-07 10:05:53 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-07 10:30:45 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 10:30:54 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5528ac1cba36eba4cc17cedb2ad137432e49668
Cr-Commit-Position: refs/heads/master@{#31142}

Powered by Google App Engine
This is Rietveld 408576698