Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: chrome/browser/signin/easy_unlock_service.cc

Issue 1372283002: Hook up ProximityAuthSystem in EasyUnlockService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth_connection
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/easy_unlock_service.cc
diff --git a/chrome/browser/signin/easy_unlock_service.cc b/chrome/browser/signin/easy_unlock_service.cc
index 377e8aee5636d7a763490438edad27f23b4ef897..e11a011d494ae38cb218bc28c1e1ad09b0773762 100644
--- a/chrome/browser/signin/easy_unlock_service.cc
+++ b/chrome/browser/signin/easy_unlock_service.cc
@@ -31,11 +31,12 @@
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/pref_names.h"
#include "components/pref_registry/pref_registry_syncable.h"
-#include "components/proximity_auth/ble/proximity_auth_ble_system.h"
#include "components/proximity_auth/cryptauth/cryptauth_client_impl.h"
#include "components/proximity_auth/cryptauth/cryptauth_device_manager.h"
#include "components/proximity_auth/cryptauth/cryptauth_enrollment_manager.h"
#include "components/proximity_auth/cryptauth/secure_message_delegate.h"
+#include "components/proximity_auth/logging/logging.h"
+#include "components/proximity_auth/proximity_auth_system.h"
#include "components/proximity_auth/screenlock_bridge.h"
#include "components/proximity_auth/switches.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
@@ -283,10 +284,6 @@ void EasyUnlockService::RegisterProfilePrefs(
proximity_auth::CryptAuthGCMManager::RegisterPrefs(registry);
proximity_auth::CryptAuthDeviceManager::RegisterPrefs(registry);
proximity_auth::CryptAuthEnrollmentManager::RegisterPrefs(registry);
-
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- proximity_auth::switches::kEnableBluetoothLowEnergyDiscovery))
- proximity_auth::ProximityAuthBleSystem::RegisterPrefs(registry);
}
// static
@@ -525,14 +522,14 @@ void EasyUnlockService::AttemptAuth(const std::string& user_id,
if (!auth_attempt_->Start())
auth_attempt_.reset();
- // TODO(tengs): We notify ProximityAuthBleSystem whenever unlock attempts are
+ // TODO(tengs): We notify ProximityAuthSystem whenever unlock attempts are
// attempted. However, we ideally should refactor the auth attempt logic to
// the proximity_auth component.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
proximity_auth::switches::kEnableBluetoothLowEnergyDiscovery) &&
auth_attempt_type == EasyUnlockAuthAttempt::TYPE_UNLOCK &&
- proximity_auth_ble_system_) {
- proximity_auth_ble_system_->OnAuthAttempted(user_id);
+ proximity_auth_system_) {
+ proximity_auth_system_->OnAuthAttempted(user_id);
}
}
@@ -649,6 +646,7 @@ void EasyUnlockService::Shutdown() {
ResetScreenlockState();
bluetooth_detector_.reset();
+ proximity_auth_system_.reset();
#if defined(OS_CHROMEOS)
power_monitor_.reset();
#endif
@@ -669,16 +667,6 @@ void EasyUnlockService::UpdateAppState() {
app_manager_->LoadApp();
NotifyUserUpdated();
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- proximity_auth::switches::kEnableBluetoothLowEnergyDiscovery) &&
- GetType() == EasyUnlockService::TYPE_REGULAR &&
- !proximity_auth_ble_system_) {
- proximity_auth_ble_system_.reset(
- new proximity_auth::ProximityAuthBleSystem(
- proximity_auth::ScreenlockBridge::Get(), &proximity_auth_client_,
- profile_->GetPrefs()));
- }
-
#if defined(OS_CHROMEOS)
if (!power_monitor_)
power_monitor_.reset(new PowerMonitor(this));
@@ -697,7 +685,7 @@ void EasyUnlockService::UpdateAppState() {
if (!bluetooth_waking_up) {
app_manager_->DisableAppIfLoaded();
ResetScreenlockState();
- proximity_auth_ble_system_.reset();
+ proximity_auth_system_.reset();
#if defined(OS_CHROMEOS)
power_monitor_.reset();
#endif
@@ -839,6 +827,23 @@ EasyUnlockAuthEvent EasyUnlockService::GetPasswordAuthEvent() const {
return EASY_UNLOCK_AUTH_EVENT_COUNT;
}
+void EasyUnlockService::OnRemoteDeviceChanged(
+ const proximity_auth::RemoteDevice* remote_device) {
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ proximity_auth::switches::kEnableBluetoothLowEnergyDiscovery))
+ return;
+
+ if (remote_device) {
+ PA_LOG(INFO) << "Remote device changed, recreating ProximityAuthSystem.";
+ proximity_auth_system_.reset(new proximity_auth::ProximityAuthSystem(
+ *remote_device, proximity_auth_client()));
+ proximity_auth_system_->Start();
+ } else {
+ PA_LOG(INFO) << "Remote device removed, destroying ProximityAuthSystem.";
+ proximity_auth_system_.reset();
+ }
+}
+
#if defined(OS_CHROMEOS)
void EasyUnlockService::OnCryptohomeKeysFetchedForChecking(
const std::string& user_id,
@@ -872,6 +877,13 @@ void EasyUnlockService::PrepareForSuspend() {
app_manager_->DisableAppIfLoaded();
if (screenlock_state_handler_ && screenlock_state_handler_->IsActive())
UpdateScreenlockState(ScreenlockState::BLUETOOTH_CONNECTING);
+ if (proximity_auth_system_)
+ proximity_auth_system_->OnSuspend();
+}
+
+void EasyUnlockService::OnSuspendDone() {
+ if (proximity_auth_system_)
+ proximity_auth_system_->OnSuspendDone();
}
void EasyUnlockService::EnsureTpmKeyPresentIfNeeded() {

Powered by Google App Engine
This is Rietveld 408576698