content/renderer/pepper/pepper_compositor_host.cc - Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_compositor_host.cc

Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pointfconvert-gfx: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/picture_layer_impl_unittest.cc ('K') | « content/common/input/synthetic_tap_gesture_params.h ('k') | content/renderer/pepper/pepper_graphics_2d_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_compositor_host.cc

diff --git a/content/renderer/pepper/pepper_compositor_host.cc b/content/renderer/pepper/pepper_compositor_host.cc

index c2d46856780995f6aaf9d8c435240e858385f349..e8343ee38abfa2f4b769c02d383004dfd7b60166 100644

--- a/content/renderer/pepper/pepper_compositor_host.cc

+++ b/content/renderer/pepper/pepper_compositor_host.cc

@@ -245,14 +245,15 @@ void PepperCompositorHost::UpdateLayer(

layer_->ReplaceChild(layer.get(), clip_parent);

clip_parent->AddChild(layer);

}

- gfx::Point position = PP_ToGfxPoint(new_layer->common.clip_rect.point);

+ auto position =

+ gfx::PointF(PP_ToGfxPoint(new_layer->common.clip_rect.point));

clip_parent->SetPosition(position);

clip_parent->SetBounds(PP_ToGfxSize(new_layer->common.clip_rect.size));

- layer->SetPosition(gfx::Point(-position.x(), -position.y()));

+ layer->SetPosition(gfx::PointF(-position.x(), -position.y()));

} else if (layer->parent() != layer_.get()) {

// Remove the clip parent layer.

layer_->ReplaceChild(layer->parent(), layer);

- layer->SetPosition(gfx::Point());

+ layer->SetPosition(gfx::PointF());

}

if (new_layer->color) {