content/browser/renderer_host/input/touch_selection_controller_client_aura.cc - Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pointfconvert-gfx: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/picture_layer_impl_unittest.cc ('K') | « content/browser/renderer_host/input/touch_action_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

index ada3e9f2fc7549240bf0d1d5061a92a562044e58..c47605c2535a685d5c62ffbc8bc24e4a66535351 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

@@ -165,7 +165,7 @@ void TouchSelectionControllerClientAura::ShowQuickMenu() {

// bounds.

gfx::PointF origin = rect.origin();

gfx::PointF bottom_right = rect.bottom_right();

- gfx::Rect client_bounds = rwhva_->GetNativeView()->bounds();

+ auto client_bounds = gfx::RectF(rwhva_->GetNativeView()->bounds());

origin.SetToMax(client_bounds.origin());

bottom_right.SetToMin(client_bounds.bottom_right());

if (origin.x() > bottom_right.x() || origin.y() > bottom_right.y())