content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc - Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc

Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pointfconvert-event: mandol_line Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_target_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc

index c8b2cee92d7d7c1dec47937d25dd167613fedbf9..437c5e52468180e78f7b1eead1332cdec8f76681 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc

@@ -355,7 +355,7 @@ IN_PROC_BROWSER_TEST_F(TouchSelectionControllerClientAuraTest, HiddenOnScroll) {

// Put a finger down: the quick menu should go away, while touch handles stay

// there.

- ui::TouchEvent touch_down(ui::ET_TOUCH_PRESSED, gfx::PointF(10, 10), 0,

+ ui::TouchEvent touch_down(ui::ET_TOUCH_PRESSED, gfx::Point(10, 10), 0,

ui::EventTimeForNow());

rwhva->OnTouchEvent(&touch_down);

EXPECT_EQ(ui::TouchSelectionController::SELECTION_ACTIVE,

@@ -385,7 +385,7 @@ IN_PROC_BROWSER_TEST_F(TouchSelectionControllerClientAuraTest, HiddenOnScroll) {

EXPECT_FALSE(ui::TouchSelectionMenuRunner::GetInstance()->IsRunning());

// Lift the finger up: the quick menu should re-appear.

- ui::TouchEvent touch_up(ui::ET_TOUCH_RELEASED, gfx::PointF(10, 10), 0,

+ ui::TouchEvent touch_up(ui::ET_TOUCH_RELEASED, gfx::Point(10, 10), 0,

ui::EventTimeForNow());

rwhva->OnTouchEvent(&touch_up);

EXPECT_EQ(ui::TouchSelectionController::SELECTION_ACTIVE,