ui/views/controls/textfield/textfield.cc - Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pointfconvert-event: browsertests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 039102b748e1a4916a8a98570d38894130802a2b..4e8ec8713a52c897cb114eb4f56d31964248f64d 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -1157,8 +1157,8 @@ void Textfield::GetSelectionEndPoints(ui::SelectionBound* anchor,

gfx::Rect r1 = render_text->GetCursorBounds(start_sel, true);

gfx::Rect r2 = render_text->GetCursorBounds(sel, true);

- anchor->SetEdge(r1.origin(), r1.bottom_left());

- focus->SetEdge(r2.origin(), r2.bottom_left());

+ anchor->SetEdge(gfx::PointF(r1.origin()), gfx::PointF(r1.bottom_left()));

+ focus->SetEdge(gfx::PointF(r2.origin()), gfx::PointF(r2.bottom_left()));

// Determine the SelectionBound's type for focus and anchor.

// TODO(mfomitchev): Ideally we should have different logical directions for

« ui/events/event_unittest.cc ('K') | « ui/gfx/geometry/point_unittest.cc ('k') | ui/views/touchui/touch_selection_controller_impl_unittest.cc » ('j') | no next file with comments »