Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1372233002: Fix |Array| and iterator_util.h's Iterator operator->() behavior (Closed)

Created:
5 years, 2 months ago by vardhan
Modified:
5 years, 2 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix |Array| and iterator_util.h's Iterator operator->() behavior R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6d08abd56327e359ae89465630aae20ce1d213d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/public/cpp/bindings/array.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/iterator_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/iterator_test_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vardhan
5 years, 2 months ago (2015-09-28 20:49:25 UTC) #1
viettrungluu
lgtm
5 years, 2 months ago (2015-09-28 21:34:49 UTC) #2
vardhan
5 years, 2 months ago (2015-09-28 21:36:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6d08abd56327e359ae89465630aae20ce1d213d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698