Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1372213005: [turbofan] Greedy: smarter last resort splitting. (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: smarter last resort splitting. When all heuristics fail, we run a "last resort" heuristic. Before, it was splitting at the first found splittable position either before or after a use position. That turns out to be too naive: it may split in loops, when alternative split positions exist outside loops. This change chooses a "before" use case location that is outside the loop. Committed: https://crrev.com/d5a9dd6539d49f0fc7bd2d48f4783520a9e3b88d Cr-Commit-Position: refs/heads/master@{#30990}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -49 lines) Patch
M src/compiler/greedy-allocator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 4 chunks +27 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 2 months ago (2015-09-29 00:47:58 UTC) #2
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-09-29 03:43:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372213005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372213005/20001
5 years, 2 months ago (2015-09-29 03:45:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 03:47:28 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 03:47:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5a9dd6539d49f0fc7bd2d48f4783520a9e3b88d
Cr-Commit-Position: refs/heads/master@{#30990}

Powered by Google App Engine
This is Rietveld 408576698