Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1372203003: Fix various issues in the roll_gn script. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
brettw, Bons
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix various issues in the roll_gn script. This patch address a bunch of issues people have found in the roll_gn script: - Fixes yet another bug where we weren't waiting for the try jobs to finish. - Fixes a bug where we were adding an extra '\n' onto the DEPS file in the final roll CL. - Closes the 'build_gn' CL once the build has completed. - Adds better logging at the end of the 'wait' and 'roll_buildtools' steps. - Removes mac_chromium_gn_rel from CQ_EXTRA_TRYBOTS, since it is part of the default set now. R=brettw@chromium.org, andybons@chromium.org BUG= Committed: https://crrev.com/513d94882c9720688a3e3f67da2b0a529e27b7b9 Cr-Commit-Position: refs/heads/master@{#351141}

Patch Set 1 #

Patch Set 2 : remove mac_chromium_gn_rel from CQ_EXTRA_TRYBOTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M tools/gn/bin/roll_gn.py View 1 6 chunks +34 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 2 months ago (2015-09-28 19:46:56 UTC) #1
brettw
lgtm
5 years, 2 months ago (2015-09-28 20:06:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372203003/20001
5 years, 2 months ago (2015-09-28 20:16:01 UTC) #4
Bons
lgtm
5 years, 2 months ago (2015-09-28 20:23:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 20:58:00 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:59:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/513d94882c9720688a3e3f67da2b0a529e27b7b9
Cr-Commit-Position: refs/heads/master@{#351141}

Powered by Google App Engine
This is Rietveld 408576698