Adds macros to the MIPS assembler for detecting overflow.

runtime/vm/assembler_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/assembler.h"
 #include "vm/runtime_entry.h"
 #include "vm/simulator.h"
@@ skipping 61 matching lines @@
       lui(rd, Immediate(offset_high));
       addu(rd, rd, PP);
       lw(rd, Address(rd, offset_low));
     } else {
       lw(rd, Address(PP, offset_low));
     }
   }
 }
 
 
+void Assembler::AdduDetectOverflow(Register rd, Register rs, Register rt,
+                                   Register ro) {
+  ASSERT(rd != ro);
+  ASSERT(rd != TMP);
+  ASSERT(ro != TMP);
+  ASSERT(ro != rs);
+  ASSERT(ro != rt);
+
+  if ((rs == rt) && (rd == rs)) {
+    ASSERT(rd != T9);

[regis, 2013/04/05 23:23:45]

This macro should take a scratch register argument that would be used here
instead of implicitly using T9: ASSERT(scratch != kNoRegister)
The caller is free to pass kNoRegister if no scratch register will be required.

[zra, 2013/04/06 00:04:19]

I thought it might be clearer to require a scratch register and to use that
instead of TMP, and then to use TMP instead of T9 in the case that rd = rs = rt.
I think it might be too hard to remember to provide a scratch register only in
this one weird case.

+    ASSERT(ro != T9);
+    mov(T9, rt);
+    rt = T9;
+  }
+
+  if (rd == rs) {
+    mov(TMP, rs);  // Preserve rs.
+    addu(rd, rs, rt);  // rs is overwritten.
+    xor_(TMP, rd, TMP);  // Original rs.
+    xor_(ro, rd, rt);
+    and_(ro, ro, TMP);
+  } else if (rd == rt) {
+    mov(TMP, rt);  // Preserve rt.
+    addu(rd, rs, rt);  // rt is overwritten.
+    xor_(TMP, rd, TMP);  // Original rt.
+    xor_(ro, rd, rs);
+    and_(ro, ro, TMP);
+  } else {
+    addu(rd, rs, rt);
+    xor_(ro, rd, rs);
+    xor_(TMP, rd, rt);
+    and_(ro, TMP, ro);
+  }
+}
+
+
+void Assembler::AddiuDetectOverflow(Register rt, Register rs,
+                                    const Immediate& imm, Register ro) {

[regis, 2013/04/05 23:23:45]

ditto, scratch argument instead of T8.

[zra, 2013/04/06 00:04:19]

I decided to remove this function. Otherwise it would need multiple scratch
registers, and it's probably more readable at call sites just to load the
immediate by hand.

+  addiu(T8, ZR, imm);
+  AdduDetectOverflow(rt, rs, T8, ro);
+}
+
+
 void Assembler::LoadObject(Register rd, const Object& object) {
   // Smi's and VM heap objects are never relocated; do not use object pool.
   if (object.IsSmi()) {
     LoadImmediate(rd, reinterpret_cast<int32_t>(object.raw()));
   } else if (object.InVMHeap()) {
     // Make sure that class CallPattern is able to decode this load immediate.
     int32_t object_raw = reinterpret_cast<int32_t>(object.raw());
     const uint16_t object_low = Utils::Low16Bits(object_raw);
     const uint16_t object_high = Utils::High16Bits(object_raw);
     lui(rd, Immediate(object_high));
@@ skipping 188 matching lines @@
   b(&stop);
   Emit(reinterpret_cast<int32_t>(message));
   Bind(&stop);
   break_(Instr::kStopMessageCode);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS