Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1372173003: NaCl GN build: Remove unnecessary defines to sync with Chromium. (Closed)

Created:
5 years, 2 months ago by Sean Klein
Modified:
5 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

NaCl GN build: Remove unnecessary defines to sync with Chromium. Matches this cl: https://codereview.chromium.org/1351933003/ BUG=none R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/72d882198b437c3e9a652d2955a18bedf001e83e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M build/config/nacl/BUILD.gn View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sean Klein
5 years, 2 months ago (2015-09-28 18:23:34 UTC) #2
Mark Seaborn
LGTM, thanks
5 years, 2 months ago (2015-09-28 18:36:45 UTC) #3
Sean Klein
5 years, 2 months ago (2015-09-28 21:10:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72d882198b437c3e9a652d2955a18bedf001e83e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698