ipc/handle_win.cc - Issue 1372153002: Detecting and fixing stringprintf.h format bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/handle_win.cc

Issue 1372153002: Detecting and fixing stringprintf.h format bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing one more bug Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/handle_win.cc

diff --git a/ipc/handle_win.cc b/ipc/handle_win.cc

index 5d259059264724e8680f05f05feb00b3d4f47d72..51f3f95fb055c20af0497ec5ad6931ee0d8042a1 100644

--- a/ipc/handle_win.cc

+++ b/ipc/handle_win.cc

@@ -48,7 +48,7 @@ bool ParamTraits<HandleWin>::Read(const Message* m,

// static

void ParamTraits<HandleWin>::Log(const param_type& p, std::string* l) {

- l->append(base::StringPrintf("0x%X", p.get_handle()));

+ l->append(base::StringPrintf("0x%p", p.get_handle()));

l->append(base::IntToString(p.get_permissions()));

}