base/memory/shared_memory_win.cc - Issue 1372153002: Detecting and fixing stringprintf.h format bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_win.cc

Issue 1372153002: Detecting and fixing stringprintf.h format bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing one more bug Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/shared_memory_win.cc

diff --git a/base/memory/shared_memory_win.cc b/base/memory/shared_memory_win.cc

index 3eef9a94d33dc5a4c6e7f98c0d65a2a12b14447c..9665a7c290df672d01b7d9e83308f991673fb902 100644

--- a/base/memory/shared_memory_win.cc

+++ b/base/memory/shared_memory_win.cc

@@ -146,7 +146,7 @@ bool SharedMemory::Create(const SharedMemoryCreateOptions& options) {

// So, we generate a random name when we need to enforce read-only.

uint64_t rand_values[4];

RandBytes(&rand_values, sizeof(rand_values));

- name_ = StringPrintf(L"CrSharedMem_%016x%016x%016x%016x",

+ name_ = StringPrintf(L"CrSharedMem_%016llx%016llx%016llx%016llx",

rand_values[0], rand_values[1],

rand_values[2], rand_values[3]);

}