mojo/fetcher/network_fetcher.cc - Issue 1372153002: Detecting and fixing stringprintf.h format bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/fetcher/network_fetcher.cc

Issue 1372153002: Detecting and fixing stringprintf.h format bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Separate #if defined blocks. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/fetcher/network_fetcher.cc

diff --git a/mojo/fetcher/network_fetcher.cc b/mojo/fetcher/network_fetcher.cc

index 603cf50de6c42c017227f7e8f6a61e47d0097103..c9a37f220b16c77f722501921e53aa5412f5362c 100644

--- a/mojo/fetcher/network_fetcher.cc

+++ b/mojo/fetcher/network_fetcher.cc

@@ -90,8 +90,8 @@ void NetworkFetcher::RecordCacheToURLMapping(const base::FilePath& path,

base::FilePath map_path = temp_dir.AppendASCII(map_name);

// TODO(eseidel): Paths or URLs with spaces will need quoting.

- std::string map_entry =

- base::StringPrintf("%s %s\n", path.value().c_str(), url.spec().c_str());

+ std::string map_entry = base::StringPrintf(

+ "%" PRIsFP " %s\n", path.value().c_str(), url.spec().c_str());

// TODO(eseidel): AppendToFile is missing O_CREAT, crbug.com/450696

if (!PathExists(map_path)) {

base::WriteFile(map_path, map_entry.data(),

« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | sync/engine/model_type_worker.cc » ('j') | no next file with comments »