Detecting and fixing stringprintf.h format bugs

base/files/file_path.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // FilePath is a container for pathnames stored in a platform's native string
 // type, providing containers for manipulation in according with the
 // platform's conventions for pathnames.  It supports the following path
 // types:
 //
 //                   POSIX            Windows
@@ skipping 120 matching lines @@
 
 // An abstraction to isolate users from the differences between native
 // pathnames on different platforms.
 class BASE_EXPORT FilePath {
  public:
 #if defined(OS_POSIX)
   // On most platforms, native pathnames are char arrays, and the encoding
   // may or may not be specified.  On Mac OS X, native pathnames are encoded
   // in UTF-8.
   typedef std::string StringType;
+#define PRIsFP "s"

[Lei Zhang, 2015/09/30 18:35:01]

You should move these into their own section with documentation for how to use
them, including an example. Not everyone is going to figure out what this is.

"Isn't a PRIuS some kind of a car?"

 #elif defined(OS_WIN)
   // On Windows, for Unicode-aware applications, native pathnames are wchar_t
   // arrays encoded in UTF-16.
   typedef std::wstring StringType;
+#define PRIsFP "ls"
 #endif  // OS_WIN
 
   typedef BasicStringPiece<StringType> StringPieceType;
   typedef StringType::value_type CharType;
 
   // Null-terminated array of separators used to separate components in
   // hierarchical paths.  Each character in this array is a valid separator,
   // but kSeparators[0] is treated as the canonical separator and will be used
   // when composing pathnames.
   static const CharType kSeparators[];
@@ skipping 303 matching lines @@
 template<>
 struct hash<base::FilePath> {
   size_t operator()(const base::FilePath& f) const {
     return hash<base::FilePath::StringType>()(f.value());
   }
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 
 #endif  // BASE_FILES_FILE_PATH_H_