Detecting and fixing stringprintf.h format bugs

mojo/fetcher/network_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/fetcher/network_fetcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file.h"
 #include "base/files/file_path.h"
@@ skipping 72 matching lines @@
   // TODO(eseidel): All users of this log should move to using the map file.
   VLOG(1) << "Caching mojo app " << url << " at " << path.value();
 
   base::FilePath temp_dir;
   base::GetTempDir(&temp_dir);
   base::ProcessId pid = base::Process::Current().Pid();
   std::string map_name = base::StringPrintf("mojo_shell.%d.maps", pid);
   base::FilePath map_path = temp_dir.AppendASCII(map_name);
 
   // TODO(eseidel): Paths or URLs with spaces will need quoting.
+#ifdef OS_WIN
+  // FilePath::StringType is std::wstring on Windows
+  std::string map_entry =
+      base::StringPrintf("%ls %s\n", path.value().c_str(), url.spec().c_str());
+#else
   std::string map_entry =
       base::StringPrintf("%s %s\n", path.value().c_str(), url.spec().c_str());
+#endif
   // TODO(eseidel): AppendToFile is missing O_CREAT, crbug.com/450696
   if (!PathExists(map_path)) {
     base::WriteFile(map_path, map_entry.data(),
                     static_cast<int>(map_entry.length()));
   } else {
     base::AppendToFile(map_path, map_entry.data(),
                        static_cast<int>(map_entry.length()));
   }
 }
 
@@ skipping 136 matching lines @@
     loader_callback_.Run(nullptr);
     return;
   }
 
   response_ = response.Pass();
   loader_callback_.Run(owner.Pass());
 }
 
 }  // namespace fetcher
 }  // namespace mojo