Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1372133006: Fix unwanted float-to-double-promotions (Closed)

Created:
5 years, 2 months ago by skomski
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix unwanted float-to-double-promotions Unwanted promotions resulted into check_eq errors from this CR: https://codereview.chromium.org/1384873002/ http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/3141/steps/Check/logs/4 Found via -Wdouble-promotion. Committed: https://crrev.com/fde36818c60f5b7b1c80acbad4a99ade5556e3f5 Cr-Commit-Position: refs/heads/master@{#31125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 4 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
skomski
PTAL
5 years, 2 months ago (2015-10-06 13:21:45 UTC) #2
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-06 14:04:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372133006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372133006/1
5 years, 2 months ago (2015-10-06 14:19:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-06 14:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372133006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372133006/1
5 years, 2 months ago (2015-10-06 14:49:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 14:50:36 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 14:50:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fde36818c60f5b7b1c80acbad4a99ade5556e3f5
Cr-Commit-Position: refs/heads/master@{#31125}

Powered by Google App Engine
This is Rietveld 408576698