Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1372133004: Readability improvement in apply_issue. (Closed)

Created:
5 years, 2 months ago by tandrii(chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M apply_issue.py View 6 chunks +9 lines, -8 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
tandrii(chromium)
5 years, 2 months ago (2015-10-05 17:55:12 UTC) #1
tandrii(chromium)
PTAL follow up on https://codereview.chromium.org/1373363006/
5 years, 2 months ago (2015-10-05 17:55:57 UTC) #2
pgervais
lgtm! thanks for following up.
5 years, 2 months ago (2015-10-05 18:54:26 UTC) #3
tandrii(chromium)
On 2015/10/05 18:54:26, pgervais wrote: > lgtm! thanks for following up. np, I appreciate your ...
5 years, 2 months ago (2015-10-05 18:56:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372133004/1
5 years, 2 months ago (2015-10-05 18:56:36 UTC) #6
Sergey Berezin
https://codereview.chromium.org/1372133004/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1372133004/diff/1/apply_issue.py#newcode30 apply_issue.py:30: RETURN_CODE_OK = 0 # any other failure, likely patch ...
5 years, 2 months ago (2015-10-05 19:06:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297015
5 years, 2 months ago (2015-10-05 19:17:38 UTC) #9
tandrii(chromium)
5 years, 2 months ago (2015-10-05 21:51:50 UTC) #10
Message was sent while issue was closed.
On 2015/10/05 19:06:58, Sergey Berezin wrote:
> https://codereview.chromium.org/1372133004/diff/1/apply_issue.py
> File apply_issue.py (right):
> 
> https://codereview.chromium.org/1372133004/diff/1/apply_issue.py#newcode30
> apply_issue.py:30: RETURN_CODE_OK               = 0  # any other failure,
likely
> patch apply one.
> drive-by nit: that's not a failure :-)

True https://codereview.chromium.org/1383723003/

Powered by Google App Engine
This is Rietveld 408576698