Issue 137213011: Don't install new Windows git on XP machines.

Issue 137213011: Don't install new Windows git on XP machines. (Closed)

Created:
6 years, 10 months ago by Michael Moss

Modified:
6 years, 10 months ago

Reviewers:
szager, szager1, Marc-Antoine Ruel (Google), mmoss

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Don't install new Windows git on XP machines. The new git broke then XP bots because it relies on WinAPIs that are newer than XP. R=szager@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250211

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	bootstrap/win/win_tools.bat	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

szager1

https://codereview.chromium.org/137213011/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/137213011/diff/1/bootstrap/win/win_tools.bat#newcode50 bootstrap/win/win_tools.bat:50: rmdir /S /Q "%WIN_TOOLS_ROOT_DIR%\git-1.8.0_bin" Why this?

6 years, 10 months ago (2014-02-10 21:35:18 UTC) #3

mmoss

6 years, 10 months ago (2014-02-10 21:37:33 UTC) #4

szager1

On 2014/02/10 21:37:33, mmoss wrote: > https://codereview.chromium.org/137213011/diff/1/bootstrap/win/win_tools.bat > File bootstrap/win/win_tools.bat (right): > > https://codereview.chromium.org/137213011/diff/1/bootstrap/win/win_tools.bat#newcode50 > ...

6 years, 10 months ago (2014-02-10 21:43:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r250211.

Expand Messages | Collapse Messages