Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/app/theme/PRESUBMIT.py

Issue 1372113003: Add a PRESUBMIT check for broken .ico files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optimize-ico-files-modularize
Patch Set: Update copyright year. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/resources/ico_tools.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/theme/PRESUBMIT.py
diff --git a/chrome/app/theme/PRESUBMIT.py b/chrome/app/theme/PRESUBMIT.py
index 9d0fc31a957e3124a50d11366bb06577076e9f70..5c5353f75fb5205376266163dc994eb043162440 100644
--- a/chrome/app/theme/PRESUBMIT.py
+++ b/chrome/app/theme/PRESUBMIT.py
@@ -36,11 +36,13 @@ def _CommonChecks(input_api, output_api):
try:
sys.path = [resources] + old_path
- from resource_check import resource_scale_factors
+ from resource_check import resource_scale_factors, ico_files
for paths in path_scales:
results.extend(resource_scale_factors.ResourceScaleFactors(
input_api, output_api, paths).RunChecks())
+
+ results.extend(ico_files.IcoFiles(input_api, output_api).RunChecks())
finally:
sys.path = old_path
« no previous file with comments | « no previous file | tools/resources/ico_tools.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698