Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1372113002: Remove memory corruption testing from base::File(). (Closed)

Created:
5 years, 2 months ago by gavinp
Modified:
5 years, 2 months ago
Reviewers:
pasko, Lei Zhang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove memory corruption testing from base::File(). This was intended to help debug issue 424562 (see Issue 702473009 for more details), and it isn't needed any more. R=thakis@chromium.org,pasko@chromium.org,thestig@chromium.org BUG=424562 Committed: https://crrev.com/ac9c196f4e34e0e11a220484bd3192635e619617 Cr-Commit-Position: refs/heads/master@{#351194}

Patch Set 1 #

Patch Set 2 : narrowed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -163 lines) Patch
M base/files/file.h View 1 5 chunks +2 lines, -51 lines 0 comments Download
M base/files/file_posix.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M base/files/file_unittest.cc View 2 chunks +0 lines, -69 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
gavinp
thestig,pasko: PTAL. This should have been done a while ago, but better late than never. ...
5 years, 2 months ago (2015-09-28 16:02:37 UTC) #2
pasko
lgtm
5 years, 2 months ago (2015-09-28 16:09:51 UTC) #3
Lei Zhang
lgtm
5 years, 2 months ago (2015-09-28 18:55:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372113002/20001
5 years, 2 months ago (2015-09-28 18:57:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/74529)
5 years, 2 months ago (2015-09-28 20:38:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372113002/20001
5 years, 2 months ago (2015-09-28 21:38:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:58:19 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:59:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac9c196f4e34e0e11a220484bd3192635e619617
Cr-Commit-Position: refs/heads/master@{#351194}

Powered by Google App Engine
This is Rietveld 408576698