Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1372103002: [sessions] Introduce iOS implementation of LiveTab interface (Closed)

Created:
5 years, 2 months ago by blundell
Modified:
5 years, 2 months ago
Reviewers:
sdefresne, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sessions] Introduce iOS implementation of LiveTab interface This CL introduces IOSLiveTab, an iOS-specific implementation of the LiveTab interface that is backed by WebState (the iOS analogue of WebContents). BUG=371476 Committed: https://crrev.com/1529bc849551e12b793fab9d01dd1c0b0110c871 Cr-Commit-Position: refs/heads/master@{#351100}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M components/sessions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/sessions/ios/ios_live_tab.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A components/sessions/ios/ios_live_tab.cc View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
blundell
sdefresne: for iOS-specific review. sky: for OWNERS review.
5 years, 2 months ago (2015-09-28 15:22:17 UTC) #2
sdefresne
lgtm https://codereview.chromium.org/1372103002/diff/1/components/sessions/ios/ios_live_tab.h File components/sessions/ios/ios_live_tab.h (right): https://codereview.chromium.org/1372103002/diff/1/components/sessions/ios/ios_live_tab.h#newcode1 components/sessions/ios/ios_live_tab.h:1: // Copyright (c) 2011 The Chromium Authors. All ...
5 years, 2 months ago (2015-09-28 15:24:56 UTC) #3
blundell
https://codereview.chromium.org/1372103002/diff/1/components/sessions/ios/ios_live_tab.h File components/sessions/ios/ios_live_tab.h (right): https://codereview.chromium.org/1372103002/diff/1/components/sessions/ios/ios_live_tab.h#newcode1 components/sessions/ios/ios_live_tab.h:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
5 years, 2 months ago (2015-09-28 15:28:22 UTC) #4
sky
LGTM
5 years, 2 months ago (2015-09-28 17:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372103002/20001
5 years, 2 months ago (2015-09-28 18:20:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 19:19:57 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:21:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1529bc849551e12b793fab9d01dd1c0b0110c871
Cr-Commit-Position: refs/heads/master@{#351100}

Powered by Google App Engine
This is Rietveld 408576698