Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1372093003: [MD settings] adding check for this.$ to C++ callback (Closed)

Created:
5 years, 2 months ago by dschuyler
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] adding check for this.$ to C++ callback This adds a safety check in a JS call that may be called from C++. This comment/CL has more information about why this is being done: https://codereview.chromium.org/1365753003/#msg10 BUG=532739 Committed: https://crrev.com/cbe4835445c6a305b8f773ad65b5d87c253727b1 Cr-Commit-Position: refs/heads/master@{#351944}

Patch Set 1 #

Patch Set 2 : updating upstream branch #

Patch Set 3 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dschuyler
5 years, 2 months ago (2015-09-28 19:18:17 UTC) #2
Dan Beam
lgtm
5 years, 2 months ago (2015-09-28 20:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372093003/20001
5 years, 2 months ago (2015-09-28 20:58:53 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 2 months ago (2015-09-28 20:58:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372093003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372093003/40001
5 years, 2 months ago (2015-10-02 02:05:43 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-02 02:52:12 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 02:53:04 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cbe4835445c6a305b8f773ad65b5d87c253727b1
Cr-Commit-Position: refs/heads/master@{#351944}

Powered by Google App Engine
This is Rietveld 408576698