Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1372063002: [heap] Move CALL_HEAP_FUNCTION macro into factory.cc file. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move CALL_HEAP_FUNCTION macro into factory.cc file. R=hpayer@chromium.org Committed: https://crrev.com/df7df4df2aab9251a1ee4b995b58e805e0ce8800 Cr-Commit-Position: refs/heads/master@{#30985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -49 lines) Patch
M src/factory.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -38 lines 0 comments Download
M test/cctest/test-alloc.cc View 2 chunks +6 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-28 14:18:16 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-09-28 15:11:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372063002/1
5 years, 2 months ago (2015-09-28 16:11:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 18:08:23 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 18:08:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df7df4df2aab9251a1ee4b995b58e805e0ce8800
Cr-Commit-Position: refs/heads/master@{#30985}

Powered by Google App Engine
This is Rietveld 408576698