Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.js
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js
index 0943c0dd85da65f4a34129232fc8837b89c40e15..1507385d0b8caeb1802131eef7adb127efe376ab 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js
@@ -37,5 +37,24 @@ Polymer({
type: Object,
notify: true,
},
+
+ /**
+ * The content settings types supported in the UI.
+ */
+ contentSettingsTypes: {
Dan Beam 2015/10/10 01:27:39 why is this here? this should be in some constant
Finnur 2015/10/15 15:46:32 Good point. Moved to constants.js. Thanks for the
+ readOnly: true,
+ type: Object,
+ value: {
+ COOKIES: 0,
+ IMAGES: 1,
+ JAVASCRIPT: 2,
+ POPUPS: 4,
+ GEOLOCATION: 5,
+ NOTIFICATION: 6,
+ FULLSCREEN: 8,
+ CAMERA: 13,
+ MIC: 14,
+ },
+ },
},
});

Powered by Google App Engine
This is Rietveld 408576698