Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: chrome/browser/resources/settings/languages_page/languages.js

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback from Michael Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages.js
diff --git a/chrome/browser/resources/settings/languages_page/languages.js b/chrome/browser/resources/settings/languages_page/languages.js
index 33141369cf5d2523a843ea1bfa704deafa3713fa..8f033e9fd52c81fe1c647f9f2b4b1ad49d22083f 100644
--- a/chrome/browser/resources/settings/languages_page/languages.js
+++ b/chrome/browser/resources/settings/languages_page/languages.js
@@ -191,6 +191,7 @@ var preferredLanguagesPrefName = cr.isChromeOS ?
*/
Polymer({
is: 'settings-languages-singleton',
Dan Beam 2015/10/29 21:10:39 nit: \n
Finnur 2015/10/30 12:13:46 Done.
+ behaviors: [PrefsBehavior],
properties: {
/**
@@ -405,29 +406,6 @@ Polymer({
},
/**
- * Gets the pref at the given key. Asserts if the pref is not found.
- * @param {string} key
- * @return {!chrome.settingsPrivate.PrefObject}
- */
- getPref_: function(key) {
- var pref = /** @type {!chrome.settingsPrivate.PrefObject} */(
- this.get(key, this.prefs));
- assert(typeof pref != 'undefined', 'Pref is missing: ' + key);
- return pref;
- },
-
- /**
- * Sets the value of the pref at the given key. Asserts if the pref is not
- * found.
- * @param {string} key
- * @param {*} value
- */
- setPrefValue_: function(key, value) {
- this.getPref_(key);
- this.set('prefs.' + key + '.value', value);
- },
-
- /**
* Deletes the given item from the pref at the given key if the item is found.
* Asserts if the pref itself is not found or is not an Array type.
* @param {string} key

Powered by Google App Engine
This is Rietveld 408576698