Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback: CLs 4 through 7 (inclusive) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.js
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js
index 0943c0dd85da65f4a34129232fc8837b89c40e15..7dd61550384566655889723865ed2f9f9c1509fc 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js
@@ -38,4 +38,9 @@ Polymer({
notify: true,
},
},
+
+ ready: function() {
+ this.$.locationCategory.category =
Dan Beam 2015/10/19 07:18:05 why wouldn't the location category itself do this?
Finnur 2015/10/19 13:53:58 I'm not sure I follow. Remember... there is no loc
+ siteSettings.ContentSettingsTypes.GEOLOCATION;
+ },
});

Powered by Google App Engine
This is Rietveld 408576698