Flesh out the location-page class to make it more general.

chrome/browser/ui/webui/settings/content_settings_handler.cc

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/settings/content_settings_handler.h"
+
+#include "base/bind.h"
+#include "components/content_settings/core/common/content_settings_types.h"
+#include "content/public/browser/web_ui.h"
+
+namespace settings {
+
+ContentSettingsHandler::ContentSettingsHandler() {
+}
+
+ContentSettingsHandler::~ContentSettingsHandler() {
+}
+
+void ContentSettingsHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback(
+      "fetchContentSettingsData",
+      base::Bind(&ContentSettingsHandler::HandleFetchData,
+                 base::Unretained(this)));
+}
+
+void ContentSettingsHandler::HandleFetchData(
+    const base::ListValue* args) {
+  CHECK_EQ(2U, args->GetSize());
+  int content_settings_type = -1;
+  CHECK(args->GetInteger(0, &content_settings_type));
+  bool allowedList = false;

[Dan Beam, 2015/10/10 01:27:40]

cpp_var_names_like_this

+  CHECK(args->GetBoolean(1, &allowedList));
+
+  base::ListValue siteList;
+
+  // TODO(finnur): Remove this whole function once site_list.js has been
+  // converted.
+/*
+  switch (content_settings_type) {
+    case CONTENT_SETTINGS_TYPE_GEOLOCATION: {
+      if (allowedList) {
+        scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
+        entry->SetString("url", "http://foo.com");
+        siteList.Append(entry.release());
+      }
+      break;
+    }
+    default: {
+      if (allowedList) {
+        scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
+        entry->SetString("url", "http://foo.com");
+        siteList.Append(entry.release());
+
+        scoped_ptr<base::DictionaryValue> entry2(new base::DictionaryValue());
+        entry2->SetString("url", "http://bar.com");
+        siteList.Append(entry2.release());
+      }
+
+      if (!allowedList) {
+        scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
+        entry->SetString("url", "http://bar.com");
+        siteList.Append(entry.release());
+      }
+      break;
+    }
+  }
+*/
+
+  web_ui()->CallJavascriptFunction(
+      allowedList
+          ? "Settings.receiveAllowedData"
+          : "Settings.receiveBlockedData",

[Dan Beam, 2015/10/10 01:27:41]

why does it matter which one is called currently?  they both do the same thing
without differentiating

[Finnur, 2015/10/15 15:46:33]

I found that if two polymer objects try to setup a receive function with the
same name for native code to call, then only the latter object will receive both
messages.

However, we've already established that this file isn't needed (well, as soon as
we can work with dictionaries in prefs), so I've simply removed it.

+      siteList, base::FundamentalValue(true));
+}
+
+}  // namespace settings