Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-settings-advanced-page' is the settings page containing the advanced 7 * 'cr-settings-advanced-page' is the settings page containing the advanced
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 19 matching lines...) Expand all
30 notify: true, 30 notify: true,
31 }, 31 },
32 32
33 /** 33 /**
34 * The current active route. 34 * The current active route.
35 */ 35 */
36 currentRoute: { 36 currentRoute: {
37 type: Object, 37 type: Object,
38 notify: true, 38 notify: true,
39 }, 39 },
40
41 /**
42 * The content settings types supported in the UI.
43 */
44 contentSettingsTypes: {
Dan Beam 2015/10/10 01:27:39 why is this here? this should be in some constant
Finnur 2015/10/15 15:46:32 Good point. Moved to constants.js. Thanks for the
45 readOnly: true,
46 type: Object,
47 value: {
48 COOKIES: 0,
49 IMAGES: 1,
50 JAVASCRIPT: 2,
51 POPUPS: 4,
52 GEOLOCATION: 5,
53 NOTIFICATION: 6,
54 FULLSCREEN: 8,
55 CAMERA: 13,
56 MIC: 14,
57 },
58 },
40 }, 59 },
41 }); 60 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698