chrome/browser/resources/settings/site_settings/site_settings_behavior.html - Issue 1372053002: Flesh out the location-page class to make it more general.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_settings_behavior.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from Michael Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/site_settings/site_list.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_behavior.js » ('j') | chrome/browser/resources/settings/site_settings/site_settings_behavior.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
	Dan Beam 2015/10/29 21:10:39 this also depends on [at least] load_time_data and this also depends on [at least] load_time_data and assert Finnur 2015/10/30 12:13:47 Hmmm... It seems to be fine to include... <li Hmmm... It seems to be fine to include... <link rel="import" href="chrome://resources/html/assert.html"> ... but if I also add this ... <link rel="import" href="chrome://resources/html/load_time_data.html"> I get: "Unexpected condition on chrome://md-settings/advanced: should only include this file once", source: chrome://resources/js/load_time_data.js (139) Curiously, there is currently no md-settings page that includes load_time_data.html, despite many pages the use loadTimeData.getString. Dan Beam 2015/10/30 20:23:53 imports should be de-duped automatically. just ig Show quoted text On 2015/10/30 12:13:47, Finnur wrote: > Hmmm... > > It seems to be fine to include... > <link rel="import" href="chrome://resources/html/assert.html"> > ... but if I also add this ... > <link rel="import" href="chrome://resources/html/load_time_data.html"> > > I get: > "Unexpected condition on chrome://md-settings/advanced: should only include > this file once", source: chrome://resources/js/load_time_data.js (139) > > Curiously, there is currently no md-settings page that includes > load_time_data.html, despite many pages the use loadTimeData.getString. imports should be de-duped automatically. just ignore this for now
	2
	Dan Beam 2015/10/29 21:10:39 nit: remove \n nit: remove \n Finnur 2015/10/30 12:13:47 Done. Show quoted text On 2015/10/29 21:10:39, Dan Beam wrote: > nit: remove \n Done.
	3 <script src="site_settings_behavior.js"></script>

OLD	NEW