chrome/browser/resources/settings/site_settings/site_list.html - Issue 1372053002: Flesh out the location-page class to make it more general.

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_list.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from Michael Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/prefs/prefs_behavior.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.css ('k') | chrome/browser/resources/settings/site_settings/site_list.js » ('j') | chrome/browser/resources/settings/site_settings/site_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">

	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">

	9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper -menu-button.html">

	10 <link rel="import" href="chrome://md-settings/prefs/prefs_behavior.html">

	11 <link rel="import" href="chrome://md-settings/prefs/prefs_types.html">

	12 <link rel="import" href="chrome://md-settings/site_settings/constants.html">

	13 <link rel="import" href="chrome://md-settings/site_settings/site_settings_behavi or.html">

	14

	15 <dom-module id="settings-site-list">

	16 <link rel="import" type="css" href="../settings_page/settings_page.css">

	17 <link rel="import" type="css" href="site_list.css">

	18 <template>

	19 <paper-submenu id="category" hidden on-paper-submenu-open="onToggle_"

	20 on-paper-submenu-close="onToggle_">

	21 <paper-item class="menu-trigger">

	22 <div class="site-header horizontal layout">

	23 <div class="flex"

	24 >[[computeSiteListHeader_(sites_, categoryEnabled)]]</div>

	25 <iron-icon id="icon" icon="icons:expand-more"></iron-icon>

	26 </div>

	27 </paper-item>

	28 <paper-menu class="menu-content">

	29 <template is="dom-repeat" items="{{sites_}}">
	Dan Beam 2015/10/29 21:10:39 i think this will eventually need to be an iron-li i think this will eventually need to be an iron-list instead Finnur 2015/10/30 12:13:46 I addressed this previously. I'm happy to change t I addressed this previously. I'm happy to change this to an iron-list, if there's a good reason and I can get it to work, which hasn't been the case. As a test, I constructed a free-standing iron-list showing my data, but simply the act of moving it inside my paper-menu causes it to refuse to draw any content. I tried sending the iron-resize event, but that seemed to do nothing and despite playing with it for a while I was not able to get it to do what I wanted... :/ To see what I mean, you can add the following code snippet first to lines 19 and then 29 and only the former case will show the data: <iron-list items="[[sites_]]" as="item"> <template><div>url: <span>[[item.url]]</span></div></template> </iron-list> Dan Beam 2015/10/30 20:23:53 it needs an explicit height: """ Important: iron-l Show quoted text On 2015/10/30 12:13:46, Finnur wrote: > I addressed this previously. I'm happy to change this to an iron-list, if > there's a good reason and I can get it to work, which hasn't been the case. > > As a test, I constructed a free-standing iron-list showing my data, but simply > the act of moving it inside my paper-menu causes it to refuse to draw any > content. I tried sending the iron-resize event, but that seemed to do nothing > and despite playing with it for a while I was not able to get it to do what I > wanted... :/ > > To see what I mean, you can add the following code snippet first to lines 19 and > then 29 and only the former case will show the data: > > <iron-list items="[[sites_]]" as="item"> > <template><div>url: <span>[[item.url]]</span></div></template> > </iron-list> it needs an explicit height: """ Important: iron-list must ether be explicitly sized, or delegate scrolling to an explicitly sized parent. By "explicitly sized", we mean it either has an explicit CSS height property set via a class or inline style, or else is sized by other layout means (e.g. the flex or fit classes). """ https://elements.polymer-project.org/elements/iron-list Finnur 2015/11/02 10:43:47 Ah. OK. Will check in as-is and try this in a foll Ah. OK. Will check in as-is and try this in a followup.
	30 <div class="site-list horizontal layout center">

	31 <iron-icon icon="[[computeSiteIcon_(item.url)]]"

	32 item-icon></iron-icon>

	33 <div class="flex"><paper-item

	34 on-tap="onOriginTap_">[[item.url]]</paper-item></div>

	35 <paper-menu-button>

	36 <paper-icon-button icon="menu"

	37 class="dropdown-trigger"></paper-icon-button>

	38 <paper-menu id="actionMenu" class="dropdown-content"

	39 on-iron-select="onActionMenuIronSelect_">

	40 <paper-item value="[[actions_.ALLOW]]"

	41 hidden="[[!showAllowAction_]]"

	42 >[[i18n_.allowAction]]</paper-item>

	43 <paper-item value="[[actions_.BLOCK]]"

	44 hidden="[[!showBlockAction_]]"

	45 >[[i18n_.blockAction]]</paper-item>

	46 <paper-item value="[[actions_.RESET]]"

	47 >[[i18n_.resetAction]]</paper-item>

	48 </paper-menu>

	49 </paper-menu-button>

	50 </div>

	51 </template>

	52 </paper-menu>

	53 </paper-submenu>

	54 </template>

	55 <script src="site_list.js"></script>

	56 </dom-module>

OLD	NEW