Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback from Michael Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | chrome/browser/resources/settings/languages_page/languages.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html "> 2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html ">
3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html "> 3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html ">
4 <link rel="import" href="chrome://md-settings/location_page/location_page.html">
5 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html"> 4 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
6 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 5 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
6 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
7 <link rel="import" href="chrome://md-settings/site_settings/site_settings_catego ry.html">
7 8
8 <if expr="chromeos"> 9 <if expr="chromeos">
9 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html"> 10 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
10 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html "> 11 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html ">
11 </if> 12 </if>
12 13
13 <dom-module id="settings-advanced-page"> 14 <dom-module id="settings-advanced-page">
14 <link rel="import" type="css" href="advanced_page.css"> 15 <link rel="import" type="css" href="advanced_page.css">
15 <template> 16 <template>
16 <if expr="chromeos"> 17 <if expr="chromeos">
17 <settings-section i18n-values="page-title:dateTimePageTitle" 18 <settings-section i18n-values="page-title:dateTimePageTitle"
18 current-route="[[currentRoute]]" section="dateTime"> 19 current-route="[[currentRoute]]" section="dateTime">
19 <settings-date-time-page prefs="{{prefs}}"> 20 <settings-date-time-page prefs="{{prefs}}">
20 </settings-date-time-page> 21 </settings-date-time-page>
21 </settings-section> 22 </settings-section>
22 </if> 23 </if>
23 <settings-section i18n-values="page-title:siteSettingsLocation" 24 <settings-section i18n-values="page-title:siteSettingsLocation"
24 current-route="[[currentRoute]]" section="location"> 25 current-route="[[currentRoute]]" section="location">
25 <settings-location-page prefs="{{prefs}}"> 26 <site-settings-category id="locationCategory" prefs="{{prefs}}"
26 </settings-location-page> 27 current-route="{{currentRoute}}">
27 </settings-section> 28 </site-settings-category>
29 </cr-settings-section>
28 30
29 <settings-section i18n-values="page-title:privacyPageTitle" 31 <settings-section i18n-values="page-title:privacyPageTitle"
30 current-route="[[currentRoute]]" section="privacy"> 32 current-route="[[currentRoute]]" section="privacy">
31 <settings-privacy-page prefs="{{prefs}}" 33 <settings-privacy-page prefs="{{prefs}}"
32 current-route="{{currentRoute}}"> 34 current-route="{{currentRoute}}">
33 </settings-privacy-page> 35 </settings-privacy-page>
34 </settings-section> 36 </settings-section>
35 37
36 <settings-section i18n-values="page-title:languagesPageTitle" 38 <settings-section i18n-values="page-title:languagesPageTitle"
37 current-route="[[currentRoute]]" section="languages"> 39 current-route="[[currentRoute]]" section="languages">
(...skipping 12 matching lines...) Expand all
50 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features" 52 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features"
51 on desktop. --> 53 on desktop. -->
52 <settings-section i18n-values="page-title:a11yPageTitle" 54 <settings-section i18n-values="page-title:a11yPageTitle"
53 current-route="[[currentRoute]]" section="a11y"> 55 current-route="[[currentRoute]]" section="a11y">
54 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page> 56 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
55 </settings-section> 57 </settings-section>
56 </if> 58 </if>
57 </template> 59 </template>
58 <script src="advanced_page.js"></script> 60 <script src="advanced_page.js"></script>
59 </dom-module> 61 </dom-module>
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | chrome/browser/resources/settings/languages_page/languages.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698