chrome/browser/resources/settings/site_settings/site_list.html - Issue 1372053002: Flesh out the location-page class to make it more general.

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_list.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: List population Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/site_settings/constants.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.css ('k') | chrome/browser/resources/settings/site_settings/site_list.js » ('j') | chrome/browser/resources/settings/site_settings/site_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html">
	michaelpg 2015/10/22 16:11:33 add iron-icon/iron-icon.html add iron-icon/iron-icon.html Finnur 2015/10/26 14:38:04 Done. Show quoted text On 2015/10/22 16:11:33, michaelpg wrote: > add iron-icon/iron-icon.html Done.
	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
	michaelpg 2015/10/22 16:11:33 add paper-icon-button, paper-menu-button add paper-icon-button, paper-menu-button Finnur 2015/10/26 14:38:04 Done. Show quoted text On 2015/10/22 16:11:33, michaelpg wrote: > add paper-icon-button, paper-menu-button Done.
	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">

	7 <link rel="import" href="chrome://md-settings/prefs/prefs.html">
	michaelpg 2015/10/22 16:11:33 s/prefs.html/prefs_types.html s/prefs.html/prefs_types.html Finnur 2015/10/26 14:38:04 Done. Show quoted text On 2015/10/22 16:11:33, michaelpg wrote: > s/prefs.html/prefs_types.html Done.
	8 <link rel="import" href="chrome://md-settings/site_settings/constants.html">

	9 <link rel="import" href="chrome://md-settings/site_settings/site_settings_behavi or.html">

	10

	11 <dom-module id="settings-site-list">

	12 <link rel="import" type="css" href="../settings_page/settings_page.css">
	michaelpg 2015/10/22 16:11:33 o_O we don't use "../" relative paths elsewhere, I o_O we don't use "../" relative paths elsewhere, I'd say make this absolute (chrome://md-settings/) but I'm not sure if it matters. dbeam? Finnur 2015/10/26 14:38:04 dbeam is the one who requested the relative paths. dbeam is the one who requested the relative paths... :)
	13 <link rel="import" type="css" href="site_list.css">

	14 <template>

	15 <paper-submenu id="category" hidden on-paper-submenu-open="onToggle_"

	16 on-paper-submenu-close="onToggle_">

	17 <paper-item class="menu-trigger">

	18 <div class="site-header horizontal layout">

	19 <div class="flex"

	20 >[[computeSiteListHeader_(sites_, categoryEnabled)]]</div>

	21 <iron-icon id="icon" icon="icons:expand-more"></iron-icon>

	22 </div>

	23 </paper-item>

	24 <paper-menu class="menu-content">

	25 <template is="dom-repeat" items="{{sites_}}">

	26 <div class="site-list horizontal layout center">

	27 <iron-icon icon="[[computeSiteIcon_(item.url)]]"

	28 item-icon></iron-icon>

	29 <div class="flex"><paper-item

	30 on-click="onOriginClick_">[[item.url]]</paper-item></div>
	michaelpg 2015/10/22 16:11:33 on-tap on-tap Finnur 2015/10/26 14:38:04 Done. Show quoted text On 2015/10/22 16:11:33, michaelpg wrote: > on-tap Done.
	31 <paper-menu-button>

	32 <paper-icon-button icon="menu"

	33 class="dropdown-trigger"></paper-icon-button>

	34 <paper-menu id="actionMenu" class="dropdown-content"

	35 on-iron-select="onActionMenuIronSelect_">

	36 <paper-item value="[[actions_.ALLOW]]"

	37 hidden="[[!showAllowAction_]]"

	38 >[[i18n_.allowAction]]</paper-item>

	39 <paper-item value="[[actions_.BLOCK]]"

	40 hidden="[[!showBlockAction_]]"

	41 >[[i18n_.blockAction]]</paper-item>

	42 <paper-item value="[[actions_.RESET]]"

	43 >[[i18n_.resetAction]]</paper-item>

	44 </paper-menu>

	45 </paper-menu-button>

	46 </div>

	47 </template>

	48 </paper-menu>

	49 </paper-submenu>

	50 </template>

	51 <script src="site_list.js"></script>

	52 </dom-module>

OLD	NEW