Flesh out the location-page class to make it more general.

chrome/browser/resources/settings/location_page/site_list.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * 'settings-site-list' is the widget that shows Allowed and Blocked sites.
+ *
+ * Example:
+ *
+ *      <settings-site-list
+ *          category="[[category]]"
+ *          categories="[[categories]]"
+ *          category-subtype="[[allowOrBlock.BLOCK]]"
+ *          category-subtypes="[[allowOrBlock]]>
+ *      </settings-site-list>
+ *      ... other pages ...
+ *
+ * @group Chrome Settings Elements
+ * @element settings-site-list
+ */
+Polymer({
+  is: 'settings-site-list',
+
+  properties: {
+    /**
+     * Array of sites to display in the widget.
+     */
+    siteList_: {

[Dan Beam, 2015/10/19 07:18:06]

why not sites_?

[Finnur, 2015/10/19 13:53:59]

Yup. That works too. Done.

+      type: Array,
+    },
+
+    /**
+     * The ID of the category this widget is displaying data for.
+     * See |categories| for possible values.
+     */
+    category: {
+      type: Number,
+    },
+
+    /**
+     * An enum containing all the possible category numbers. Corresponds to
+     * the values found in the ContentSettingsType.
+     */
+    categories: {
+      type: Object,
+    },
+
+    /**
+      * The type of category this widget is displaying data for. Normally
+      * either ALLOW or BLOCK, representing which sites are allowed or blocked
+      * respectively.
+      */
+    categorySubtype: {
+      type: Number,
+    },
+
+    /**
+      * An enum containing the list of all possible category subtypes.
+      */
+    categorySubtypes: {
+      type: Object,
+    },

[Dan Beam, 2015/10/19 07:18:06]

don't make variables names that are only separated by an s and are copies of
other state

[Finnur, 2015/10/19 13:53:59]

This has already been removed from the more up-to-date file. Again, my apologies
for the confusion.

+
+    /**
+     * What the main toggle for the category is set to (the global default if
+     * no other policy is in effect).
+     */
+    toggleState_: {

[Dan Beam, 2015/10/19 07:18:06]

this is a bad name

why not something involving default and our global (like your description).

[Finnur, 2015/10/19 13:53:59]

Already fixed (see previous comment, one up).

+      type: Boolean,
+      value: false,
+    },
+
+    /**
+     * The site that was selected by the user in the dropdown list.
+     */
+    selectedOrigin: {
+      type: String,
+      notify: true,
+    },
+

[Dan Beam, 2015/10/19 07:18:06]

group by access (like in c++)

[Finnur, 2015/10/19 13:53:59]

Moved alongside |prefs| (in the file that matters).

+    /**
+     * Whether to show the Allow action in the action menu.
+     */
+    showAllowAction_: {
+      type: Boolean,
+    },
+
+    /**
+     * Whether to show the Block action in the action menu.
+     */
+    showBlockAction_: {
+      type: Boolean,
+    },
+
+    /**
+     * The label to show for the Allow action menu item.
+     */
+    allowActionLabel_: {
+      type: String,
+    },
+
+    /**
+     * The label to show for the Block action menu item.
+     */
+    blockActionLabel_: {
+      type: String,
+    },
+
+    /**
+     * The label to show for the Reset action menu item.
+     */
+    resetActionLabel_: {

[Dan Beam, 2015/10/19 07:18:06]

group all the labels together (and/or check out I18nBehavior)

[Finnur, 2015/10/19 13:53:59]

Already fixed.

+      type: String,
+    },
+  },
+
+  ready: function() {
+    // By default we hide and only appear if there's something to show.
+    this.hidden = true;

[Dan Beam, 2015/10/19 07:18:06]

move to the markup or CSS

[Finnur, 2015/10/19 13:53:59]

Already fixed.

+
+    this.setupActionMenu_();
+    chrome.send('fetchContentSettingsData',
+        [this.category, this.categorySubtype == this.categorySubtypes.ALLOW]);

[Dan Beam, 2015/10/19 07:18:06]

why are we not just sending the enum value?

[Finnur, 2015/10/19 13:53:59]

Already removed.

+  },
+
+  attached: function() {
+    var self = this;
+    if (this.categorySubtype == this.categorySubtypes.ALLOW) {
+      cr.define('Settings', function() {
+        return {
+          receiveAllowedData: function() {
+            return self.receiveSiteList_.apply(self, arguments);

[Dan Beam, 2015/10/19 07:18:06]

what's different?

[Finnur, 2015/10/19 13:53:59]

Already removed.

+          },
+        };
+      });
+    } else {
+      cr.define('Settings', function() {
+        return {
+          receiveBlockedData: function() {
+            return self.receiveSiteList_.apply(self, arguments);
+          },
+        };
+      });
+    }
+  },
+
+  /**
+   * Setup the values to use for the action menu.
+   * @private
+   */
+  setupActionMenu_: function() {
+    this.showAllowAction_ = this.categorySubtype == this.categorySubtypes.BLOCK;
+    this.showBlockAction_ =
+        this.categorySubtype == this.categorySubtypes.ALLOW &&
+        this.category != this.categories.FULLSCREEN;
+
+    this.allowActionLabel_ = loadTimeData.getString('siteSettingsActionAllow');
+    this.blockActionLabel_ = loadTimeData.getString('siteSettingsActionBlock');
+    this.resetActionLabel_ = loadTimeData.getString('siteSettingsActionReset');

[Dan Beam, 2015/10/19 07:18:06]

why is this being done here?

[Finnur, 2015/10/19 13:53:59]

Already removed.

+  },
+
+  /**
+   * Receive the site list and the toggle state (from the native level).
+   * @param {array} siteList The list of all sites to display for this category
+   *    subtype.
+   * @param {boolean} toggleState The state of the global toggle for this
+   *    category.
+   * @private
+   */
+  receiveSiteList_: function(siteList, toggleState) {
+    this.siteList_ = siteList;
+    this.toggleState_ = toggleState;
+    this.hidden = !this.showSiteList_(siteList, toggleState);
+  },
+
+  /**
+   * A handler for selecting a site (by clicking on the name).
+   * @private
+   */
+  handleClick_: function(event) {
+    this.selectedOrigin = event.model.item.url;
+  },
+
+  /**
+   * A handler for activating one of the menu action items.
+   * @private
+   */
+  onActionMenuIronSelect_: function(event) {
+    // TODO(finnur): Implement.
+  },
+
+  /**
+   * Returns the appropriate header value for display.
+   * @param {array} siteList The list of all sites to display for this category
+   *     subtype.
+   * @param {boolean} toggleState The state of the global toggle for this
+   *     category.
+   * @private
+   */
+  computeSiteListHeader_: function(siteList, toggleState) {
+    if (this.categorySubtype == this.categorySubtypes.ALLOW) {
+      return loadTimeData.getStringF(
+          'titleAndCount',
+          loadTimeData.getString(
+              toggleState ? 'siteSettingsAllow' : 'siteSettingsExceptions'),
+          siteList.length);
+    } else {
+      return loadTimeData.getStringF(
+          'titleAndCount',
+          loadTimeData.getString('siteSettingsBlock'),
+          siteList.length);
+    }
+  },
+
+  /**
+   * Returns true if this widget is showing the allow list.
+   * @private
+   */
+  isAllowList_: function() {
+    return this.categorySubtype == this.categorySubtypes.ALLOW;
+  },
+
+  /**
+   * Returns whether to show the site list.
+   * @param {array} siteList The list of all sites to display for this category
+   *     subtype.
+   * @param {boolean} toggleState The state of the global toggle for this
+   *     category.
+   * @private
+   */
+  showSiteList_: function(siteList, toggleState) {
+    if (this.isAllowList_())
+      return siteList.length > 0;
+    else
+      return siteList.length > 0 && toggleState;
+  },
+
+  /**
+   * Returns the icon to use for a given site.
+   * @param {string} url The url of the site to fetch the icon for.
+   * @private
+   */
+  computeSiteIcon_: function(url) {
+    return 'communication:message';  // TODO(finnur): Implement actual favicons.
+  },
+

[Dan Beam, 2015/10/19 07:18:06]

remove newline

[Finnur, 2015/10/19 13:53:59]

Already removed.

+});