Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1372043002: update-w3c-deps import using blink 0131ca248edfe6c594fa8a6e5780f55c0f4d01eb: (Closed)

Created:
5 years, 2 months ago by kojii
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update-w3c-deps import using blink 0131ca248edfe6c594fa8a6e5780f55c0f4d01eb: imported csswg-test@8d5a07ec9aaac52e62f63ca65d944f50c67597d0 imported web-platform-tests@317575aca590f56748df7c0222302bba17c37fd4 css-writing-modes-3 - Several tests updated. html/browsers/history/the-location-interface - 1 file requires support file in the same directory (crbug.com/490940) html/semantics/embedded-content/media-elements - 2 files require running .py on the server. html/semantics/forms/constraints - Several FAILs turned to PASS, expected.txt updated. mediacapture-streams - 1 test added, failure expected added. subresource-integrity - 1 test updated. webstorage - Several tests updated. TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org BUG=490511, 492664, 490940 Committed: https://crrev.com/99801a6eafecf0aeef1e82e1241eb06af1f0eae7 Cr-Commit-Position: refs/heads/master@{#351087}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -1046 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-002.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-003.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-004.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-005.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-006.xht View 2 chunks +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-007.xht View 2 chunks +6 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-007-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-008.xht View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-008-expected.xht View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-009.xht View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-009-expected.xht View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-orthogonal-vlr-003.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-orthogonal-vlr-005.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-orthogonal-vrl-002.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-orthogonal-vrl-004.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/margin-vlr-003.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/margin-vrl-002.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-column-order-002.xht View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-001-vlr.html View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-001-vlr-expected.html View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-001-vrl.html View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-001-vrl-expected.html View 1 chunk +0 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-002.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-003.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-004.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-005.xht View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-006.xht View 2 chunks +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-007.xht View 2 chunks +5 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-007-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-008.xht View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-008-expected.xht View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-009.xht View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-baseline-009-expected.xht View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-003.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-005.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-007.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-009.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-011.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-011-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-013.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-013-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-015.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-015-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-017.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vlr-017-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-002.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-004.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-006.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-008.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-010.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-010-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-012.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-012-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-014.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-014-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-016.xht View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-indent-vrl-016-expected.xht View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-orientation-012.xht View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-orientation-012-expected.xht View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-orientation-014.xht View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-fragment-into-document.html View 2 chunks +6 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-parent-into-document.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document.html View 1 chunk +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 chunk +89 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong.html View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/support/validator.js View 2 chunks +15 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/the-label-element/label-attributes.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/subresource-integrity/subresource-integrity.html View 23 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_builtins.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_clear.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_getitem.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_in.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_indexing.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_key.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_length.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_removeitem.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/webstorage/storage_setitem.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372043002/40001
5 years, 2 months ago (2015-09-28 16:47:45 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 16:55:17 UTC) #3
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/99801a6eafecf0aeef1e82e1241eb06af1f0eae7 Cr-Commit-Position: refs/heads/master@{#351087}
5 years, 2 months ago (2015-09-28 16:56:14 UTC) #4
tkent
lgtm
5 years, 2 months ago (2015-09-29 02:31:33 UTC) #5
tkent
lgtm
5 years, 2 months ago (2015-09-29 02:31:39 UTC) #6
shiva.jm
On 2015/09/29 02:31:39, tkent wrote: > lgtm @tkent and kojii, stream-ended.html test was removed in ...
5 years, 2 months ago (2015-09-29 06:50:34 UTC) #7
tkent
5 years, 2 months ago (2015-09-29 07:02:44 UTC) #8
Message was sent while issue was closed.
On 2015/09/29 at 06:50:34, shiva.jm wrote:
> stream-ended.html test was removed in CL:
> https://codereview.chromium.org/1362933003/, since
> MediaStream label, ended attributes and stop() methods are deperecated. 
> Since functionality tested in these test is already covered by other tests.
> so shall we remove these stream-ended.html and stream-ended-expected.txt added
as part of these CL?.

No.  We need to remove or update the test in the upstream.

Powered by Google App Engine
This is Rietveld 408576698