Check that directory named depot_tools appears to be full checkout

Check that directory named depot_tools appears to be full checkout

When running recipes on build slaves, the PYTHONPATH has many (many!)
things injected, one of which includes a partial checkout of
depot_tools. As a result, find_depot_tools got confused as it thought
it had found the correct directory while searching, but then failed
to import breakpad.

This makes the search at least confirm there's a file named
breakpad.py present so the later import will probably succeed.

R=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246259

[scottmg, 2014-01-22 02:49:00]

(Is there a BUG= I can reference?)

[Paweł Hajdan Jr., 2014-01-22 03:27:30]

LGTM with a comment. No bug as far as I know. Thanks!

https://codereview.chromium.org/137203009/diff/30001/tools/find_depot_tools.py
File tools/find_depot_tools.py (right):

https://codereview.chromium.org/137203009/diff/30001/tools/find_depot_tools.p...
tools/find_depot_tools.py:34: i = os.path.join(root_dir, 'depot_tools')
While you're here, let's deduplicate "os.path.join(root_dir, 'depot_tools')" (it
appears in the "if" line 33, and assignment line 34).

[scottmg, 2014-01-22 05:05:36]

https://codereview.chromium.org/137203009/diff/30001/tools/find_depot_tools.py
File tools/find_depot_tools.py (right):

https://codereview.chromium.org/137203009/diff/30001/tools/find_depot_tools.p...
tools/find_depot_tools.py:34: i = os.path.join(root_dir, 'depot_tools')
On 2014/01/22 03:27:30, Paweł Hajdan Jr. wrote:
> While you're here, let's deduplicate "os.path.join(root_dir, 'depot_tools')"
(it
> appears in the "if" line 33, and assignment line 34).

Done.

[commit-bot: I haz the power, 2014-01-22 05:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/137203009/90001

[commit-bot: I haz the power, 2014-01-22 09:31:44]

Change committed as 246259